-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/move get balance.sol from wiki #3448
Conversation
Signed-off-by: salaheldinsoliman <[email protected]>
1ff10e8
to
f06d075
Compare
Signed-off-by: salaheldinsoliman <[email protected]>
Just a small comment. Let's move this into its own subfolder. Something like how-tos. This will make it more clear that the team has to be careful when changing this docs as we import them in the wiki. Maybe even add a note about that somewhere in the files? Because we might import subparts of the code and if someone changes a line or two it will break what we show in the wiki |
@Dr-Electron I initially wanted to implement it in |
…om/iotaledger/wasp into docs/move-GetBalance.sol-from-Wiki
Yeah lets keep it in evmtest so the CI need no or just minor changes. But have a subfolder there. Maybe some day we can revisit that whole importing logic 👍 |
you can absolutely create a new directory like |
@jorgemmsilva @Dr-Electron How about a subdir |
@salaheldinsoliman sounds good to me 👍 |
I personally would just call it how_tos so it is the same as in the SDK. But yeah that sounds good. Go for it |
9c18cce
to
204b27f
Compare
Description of change
This is the first PR addressing moving Wiki contracts to the wasp repo.
A
GetBalance.sol
contract was added, alongside asolo
test for it.Links to any relevant issues
fixes issue: iotaledger/iota-wiki#1611
How the change has been tested
A
Solo
test.Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.
develop
branch as the target branch