Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonrpc): configurable eth_getLogs limits #2903

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

dessaya
Copy link
Collaborator

@dessaya dessaya commented Oct 3, 2023

Adds:

      --webapi.limits.jsonrpc.maxBlocksInLogsFilterRange int      maximum amount of blocks in eth_getLogs filter range (default 1000)
      --webapi.limits.jsonrpc.maxLogsInResult int                 maximum amount of logs in eth_getLogs result (default 10000)

@dessaya dessaya force-pushed the jsonrpc-params branch 2 times, most recently from 765b081 to 5d64a5c Compare October 5, 2023 13:31
@dessaya dessaya enabled auto-merge October 5, 2023 13:31
Name: "JSONRPC",
Params: &app.ComponentParams{
Params: map[string]any{
"jsonrpc": jsonrpc.Params,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this works - but it breaks the pattern of how we use components/packages. Also it is mutating a package variable, which feels off.

Usually we receive the parameters in some constructor and pass it down as required. In this case these parameters could be part of the webapi configuration

@dessaya dessaya merged commit 70ce533 into iotaledger:develop Oct 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants