fix(bindings/nodejs): Resolve issues with prebuilt binaries and posti…

…nstall scripts (#755) * fix(bindings/nodejs): Resolve issues with locations of prebuilt binaries * chore(bindings/nodejs): Bump prebuild-install to 6.1.4 * fix(bindings/nodejs): Use script for building from source * fix(bindings/nodejs): Fix index.node paths * chore: Add change file * fix(bindings/nodejs): Fix postinstall scripts The exit code was not being checked for commands called with spawnSync * ci: Force CI to build Node.js bindings from source * Fix Windows postinstall commands Co-authored-by: Thoralf-M <[email protected]>
iotaledger · Feb 5, 2022 · ed4eb35 · ed4eb35
1 parent 01af056
commit ed4eb35
Show file tree

Hide file tree

Showing 14 changed files with 7,137 additions and 7,341 deletions.
diff --git a/.changes/fix-prebuilds-and-postinstall-scripts.md b/.changes/fix-prebuilds-and-postinstall-scripts.md
@@ -0,0 +1,5 @@
+---
+"nodejs-binding": patch
+---
+
+Fix prebuilt binaries and postinstall scripts
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -177,7 +177,7 @@ jobs:
             ${{ matrix.os }}-stable-cargo-build-node-target-
 
       - name: Build nodejs binding
-        run: npm ci
+        run: npm ci --build-from-source
         working-directory: bindings/nodejs
 
   python-bindings:

diff --git a/bindings/nodejs/lib/binding/account.js b/bindings/nodejs/lib/binding/account.js
@@ -1,7 +1,7 @@
 // Copyright 2021 IOTA Stiftung
 // SPDX-License-Identifier: Apache-2.0
 
-const addon = require('../../index.node');
+const addon = require('../../build/Release/index.node');
 const utils = require('../utils.js');
 const { SyncedAccount } = require('./syncedAccount.js');
 

diff --git a/bindings/nodejs/lib/binding/accountManager.js b/bindings/nodejs/lib/binding/accountManager.js
@@ -1,7 +1,7 @@
 // Copyright 2021 IOTA Stiftung
 // SPDX-License-Identifier: Apache-2.0
 
-const addon = require('../../index.node');
+const addon = require('../../build/Release/index.node');
 const utils = require('../utils.js');
 const acc = require('./account.js');
 const { SyncedAccount } = require('./syncedAccount.js');

diff --git a/bindings/nodejs/lib/eventListener.js b/bindings/nodejs/lib/eventListener.js
@@ -1,7 +1,7 @@
 // Copyright 2021 IOTA Stiftung
 // SPDX-License-Identifier: Apache-2.0
 
-const addon = require('../index.node');
+const addon = require('../build/Release/index.node');
 const { listen, eventListenerNew, removeEventListeners } = addon;
 
 class EventListener {

diff --git a/bindings/nodejs/lib/index.js b/bindings/nodejs/lib/index.js
@@ -1,7 +1,7 @@
 // Copyright 2021 IOTA Stiftung
 // SPDX-License-Identifier: Apache-2.0
 
-const addon = require('../index.node');
+const addon = require('../build/Release/index.node');
 const mh = require('./messages/messageHandler.js');
 const el = require('./eventListener.js');
 const amm = require('./messages/accountManager.js');

diff --git a/bindings/nodejs/lib/messages/messageHandler.js b/bindings/nodejs/lib/messages/messageHandler.js
@@ -1,7 +1,7 @@
 // Copyright 2021 IOTA Stiftung
 // SPDX-License-Identifier: Apache-2.0
 
-const addon = require('../../index.node');
+const addon = require('../../build/Release/index.node');
 const utils = require('../utils.js');
 
 let { sendMessage, messageHandlerNew } = addon;