fix: workflow doesn't support matrix exclusions (#1374)

* fix: workflow doesn't support matrix exclusions * fix: revert strip.js for locating index.node * feat: add changelog Co-authored-by: Mark Nardi <[email protected]>
iotaledger · Aug 19, 2022 · e9cc4b7 · e9cc4b7
1 parent ff7a45e
commit e9cc4b7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 17 deletions.
diff --git a/.changes/revert-strip.md b/.changes/revert-strip.md
@@ -0,0 +1,5 @@
+---
+"nodejs-binding": patch
+---
+
+Striping index.node from the correct path
diff --git a/.github/workflows/covector-version-or-publish.yml b/.github/workflows/covector-version-or-publish.yml
@@ -65,10 +65,12 @@ jobs:
         exclude:
           # GLIBC_2.28 is only available with a newer ubuntu version
           - os: ubuntu-18.04
-            node-version: ['18.x']
+            node-version: '18.x'
           # ubuntu-18.04 is needed for node 14.x and 16.x
           - os: ubuntu-latest
-            node-version: ['14.x', '16.x']
+            node-version: '14.x'
+          - os: ubuntu-latest
+            node-version: '16.x'
 
     steps:
       - uses: actions/checkout@v2

diff --git a/bindings/nodejs/scripts/strip.js b/bindings/nodejs/scripts/strip.js
@@ -3,19 +3,6 @@ const { spawnSync } = require('child_process');
 
 // Based on https://github.com/prebuild/prebuild/blob/master/strip.js
 
-if (process.platform === 'win32') {
-    // strip doesn't exist on Windows
-    return;
-}
-
-const binaryPath = resolve(__dirname, '../build/Release/index.node');
+const binaryPath = resolve(__dirname, '../index.node');
 const stripArgs = process.platform === 'darwin' ? '-Sx' : '--strip-all';
-const { status } = spawnSync('strip', [stripArgs, binaryPath], {
-    stdio: 'inherit',
-});
-
-if (status === null) {
-    process.exit(1);
-} else if (status > 0) {
-    process.exit(status);
-}
+spawnSync('strip', [stripArgs, binaryPath], { stdio: 'inherit' });