Skip to content

Commit

Permalink
chore: update to ubuntu 20.04 (#1384)
Browse files Browse the repository at this point in the history
* chore: upgrade deprecated ubuntu version to latest

* chore: changed file to re-trigger covectord
  • Loading branch information
Tuditi authored Aug 22, 2022
1 parent 3c07d01 commit 2b5fd77
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"nodejs-binding": patch
---

Update prebuild-install to 7.1.1 and specify building for electron latest versions.
Update prebuild-install to 7.1.1 and specify building for electron latest version.
17 changes: 5 additions & 12 deletions .github/workflows/covector-version-or-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
version-or-publish:
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
outputs:
change: ${{ steps.covector.outputs.change }}
commandRan: ${{ steps.covector.outputs.commandRan }}
Expand Down Expand Up @@ -59,18 +59,11 @@ jobs:
# The GitHub hosted Windows 2022 image comes with Visual Studio 2022, but node-gyp
# (which is used by neon-sys) sadly fails to recognize it. As a mitigation, we still run the
# tests on Windows 2019, until we can figure out a way to fix the problem.
# NOTE: Using Ubuntu 18.04 to provide glibc compatibility. (#588)
os: [ubuntu-18.04, ubuntu-latest, macos-latest, windows-2019]
os: [ubuntu-latest, macos-latest, windows-2019]
node-version: ['14.x', '16.x', '18.x']
exclude:
# GLIBC_2.28 is only available with a newer ubuntu version
- os: ubuntu-18.04
node-version: '18.x'
# ubuntu-18.04 is needed for node 14.x and 16.x
- os: ubuntu-latest
node-version: '14.x'
- os: ubuntu-latest
node-version: '16.x'

steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -151,7 +144,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-18.04, macos-latest, windows-2019]
os: [ubuntu-latest, macos-latest, windows-2019]

steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -180,14 +173,14 @@ jobs:

- name: Get current date
run: echo "CURRENT_DATE=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
if: matrix.os == 'macos-latest' || matrix.os == 'ubuntu-18.04'
if: matrix.os == 'macos-latest' || matrix.os == 'ubuntu-latest'

- name: Get current date
if: matrix.os == 'windows-2019'
run: echo "CURRENT_DATE=$(Get-Date -Format "yyyy-MM-dd")" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append

- name: Install required packages (Ubuntu)
if: matrix.os == 'ubuntu-18.04'
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get update
sudo apt-get install libudev-dev libusb-1.0-0-dev
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/python_binding_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-18.04, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.6, 3.7, 3.8, 3.9]
include:
- os: ubuntu-18.04
- os: ubuntu-latest
identifier: linux
python: python3
- os: macos-latest
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install required packages (Ubuntu)
if: matrix.os == 'ubuntu-18.04'
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get update
sudo apt-get install libudev-dev libusb-1.0-0-dev
Expand Down

0 comments on commit 2b5fd77

Please sign in to comment.