Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #4

Merged
merged 13 commits into from
Dec 6, 2023
Merged

Improvements #4

merged 13 commits into from
Dec 6, 2023

Conversation

abdulmth
Copy link
Contributor

@abdulmth abdulmth commented Dec 4, 2023

Addresses Todos in #3

@abdulmth abdulmth marked this pull request as ready for review December 5, 2023 22:35
@abdulmth abdulmth requested a review from UMR1352 December 6, 2023 09:34
UMR1352
UMR1352 requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@UMR1352 UMR1352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Fix the typos and it should be ok

src/api_test.rs Outdated Show resolved Hide resolved
src/api_test.rs Outdated Show resolved Hide resolved
src/api_test.rs Show resolved Hide resolved
src/encoder.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
@abdulmth abdulmth merged commit a17b639 into main Dec 6, 2023
7 checks passed
@abdulmth abdulmth deleted the feat/code-improvements branch December 6, 2023 11:13
@abdulmth abdulmth mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UMR1352 UMR1352 UMR1352 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulmth @UMR1352