Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON Pointer for conceal #10

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Use JSON Pointer for conceal #10

merged 6 commits into from
Feb 5, 2024

Conversation

abdulmth
Copy link
Contributor

@abdulmth abdulmth commented Feb 4, 2024 •
edited
Loading

Use JSON pointer to conceal elements instead of string arrays, which enables users to conceal object elements located inside arrays and combines conceal and conceal_array_entry to only conceal.

This PR also

  • fixes a bug when decoding nested object elements nested in arrays.
  • bumps version to 0.2.0.
  • adds a changelog file.
  • adds HEADER_TYP constant for convenience when creating JWT.

@abdulmth abdulmth requested a review from UMR1352 February 4, 2024 17:22
UMR1352
UMR1352 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@UMR1352 UMR1352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

src/decoder.rs Outdated Show resolved Hide resolved
@abdulmth abdulmth requested a review from eike-hass February 5, 2024 10:31
@eike-hass eike-hass mentioned this pull request Feb 5, 2024
Closed
eike-hass
eike-hass approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@eike-hass eike-hass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing improvement!

@abdulmth abdulmth merged commit 43a239f into main Feb 5, 2024
7 checks passed
@abdulmth abdulmth deleted the feat/use-json-pointer branch February 5, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UMR1352 UMR1352 UMR1352 approved these changes

@eike-hass eike-hass eike-hass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdulmth @eike-hass @UMR1352