chore: remove Ins::GetVersionStr (#20)

iotaledger · Sep 5, 2024 · 050fdea · 050fdea
1 parent fe729ce
commit 050fdea
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/docs/apdu.md b/docs/apdu.md
@@ -5,14 +5,13 @@ The messaging format of the app uses the [Block Protocol](/docs/block-protocol.m
 All commands use `CLA = 0x00`.
 The `P1` and `P2` fields are reserved for future use and must be set to `0` in all messages.
 
-| CLA | INS | COMMAND NAME    | DESCRIPTION                                             |
-| --- | --- | --------------- | ------------------------------------------------------- |
-| 00  | 00  | GET_VERSION     | Gets the app version in machine readable format (bytes) |
-| 00  | 01  | VERIFY_ADDRESS  | Shows the Address on device for a BIP32 path            |
-| 00  | 02  | GET_PUBKEY      | Gets the Public Key and Address for a BIP32 path        |
-| 00  | 03  | SIGN_TX         | Sign Transaction                                        |
-| 00  | FE  | GET_VERSION_STR | Gets the app version in string                          |
-| 00  | FF  | QUIT_APP        | Quits the app                                           |
+| CLA | INS | COMMAND NAME   | DESCRIPTION                                             |
+| --- | --- | -------------- | ------------------------------------------------------- |
+| 00  | 00  | GET_VERSION    | Gets the app version in machine readable format (bytes) |
+| 00  | 01  | VERIFY_ADDRESS | Shows the Address on device for a BIP32 path            |
+| 00  | 02  | GET_PUBKEY     | Gets the Public Key and Address for a BIP32 path        |
+| 00  | 03  | SIGN_TX        | Sign Transaction                                        |
+| 00  | FF  | QUIT_APP       | Quits the app                                           |
 
 ### GET_VERSION
 

diff --git a/rust-app/src/implementation.rs b/rust-app/src/implementation.rs
@@ -806,7 +806,6 @@ pub fn handle_apdu_async(io: HostIO, ins: Ins, settings: Settings) -> APDUsFutur
                 trace!("Handling sign");
                 NoinlineFut(sign_apdu(io, settings)).await;
             }
-            Ins::GetVersionStr => {}
             Ins::Exit => ledger_device_sdk::exit_app(0),
         }
     }

diff --git a/rust-app/src/interface.rs b/rust-app/src/interface.rs
@@ -81,7 +81,6 @@ pub enum Ins {
     VerifyAddress = 1,
     GetPubkey = 2,
     Sign = 3,
-    GetVersionStr = 0xfe,
     Exit = 0xff,
 }