feat(iota-genesis-builder): snapshot test data setup #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Jun 20, 2024
Thoralf-M
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Milestone diffs aren't updated and outputs/their headers aren't verified in any way, which is fine for our test case here, but could potentially lead to errors (total supply could overflow) when trying to analyze it with other tools. Just mentioning it here so you're aware
Yeah I've purposely ignored the milestone diffs for now as it didn't contribute to the test and the snapshot parser interface doesn't even allow it for now. I'll create a new issue. |
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* initial add_snapshot_test_data setup * increment snapshot header output count * add new outputs to snapshot * change the header total supply * add some comments * rename and add comment * rename example
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* initial add_snapshot_test_data setup * increment snapshot header output count * add new outputs to snapshot * change the header total supply * add some comments * rename and add comment * rename example
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* initial add_snapshot_test_data setup * increment snapshot header output count * add new outputs to snapshot * change the header total supply * add some comments * rename and add comment * rename example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760
The
dummymodule is just here to quickly verify that everything works, it will be removed in the next PR.Each subsequent PR for #611 should add a new module providing a
fn outputs() -> Vec<(OutputHeader, Output)>.