-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Staking reward generation through inflation #757
Closed
valeriyr
wants to merge
42
commits into
develop
from
l1sc/issue-153-staking-reward-through-inflation
Closed
Changes from 27 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
3cb1f1b
feat(iota-types): staking params were changed according new requirements
valeriyr 9f2b264
feat: store IOTA's TreasutyCap in SystemObject
valeriyr d336e71
fix(iota-framework): fixed lock files
valeriyr 792afc1
feat(iota-config): turn off stake subsidy by changing default params
valeriyr 55cd94c
feat(iota-framework): added IOTA burn/mint functions
valeriyr 33297be
feat: Remove parts of stake subsidy fund
PhilippGackstatter 68b87c1
feat: Implement increase/decrease supply based on target reward
PhilippGackstatter e67f56f
feat: Add validator_target_reward and pass to advance_epoch
PhilippGackstatter c1f310f
feat: Test supply change
PhilippGackstatter a5311d3
Merge remote-tracking branch 'origin/develop' into l1sc/issue-153-sta…
PhilippGackstatter 23f5cc2
Merge branch 'develop' into l1sc/issue-153-staking-reward-through-inf…
Dkwcs b75b183
Merge branch 'develop' into l1sc/issue-153-staking-reward-through-inf…
Dkwcs 4c6461b
fix: Set IOTA supply in Rust to correct value
PhilippGackstatter b594f40
fix: Add `TreasuryCap` to the system state rust struct
PhilippGackstatter 2cd8c1b
Merge branch 'develop' into l1sc/issue-153-staking-reward-through-inf…
Dkwcs fbbccd9
fix: Add TreasuryCap to the system state rust struct v1
Dkwcs eca5fc5
feat: Remove stake subsidy fund on move side
PhilippGackstatter d31a458
Merge remote-tracking branch 'origin/develop' into l1sc/issue-153-sta…
PhilippGackstatter bd4e36f
feat: Enable burning remainder supply in distribution schedule
PhilippGackstatter 83ace78
feat: Align Iota System State Rust with Move types
PhilippGackstatter fca23c9
feat: Remove stake subsidy entry from inspector
PhilippGackstatter 6bf9caf
feat: Mint and burn gas coin supply in genesis PTB
PhilippGackstatter e8034f8
feat: Update docs of change move modules
PhilippGackstatter 782df31
feat(iota-framework): storage deposits basic implementation
Dkwcs 7cb1fc6
feat(iota-framework): remove storage_fund earnings rewards(storage_fu…
Dkwcs 4349f80
refactor(iota-framework): clear storage_fund_reinvest_rate variable …
Dkwcs 97c9c58
feat: Compute the total validator reward based on target reward
PhilippGackstatter 5913666
feat: Add total iota supply to system state summary
PhilippGackstatter 31cafc9
feat: Remove stake subsidy params form state summary
PhilippGackstatter 5615ebb
feat: Remove more stake subsidy related params
PhilippGackstatter ae3ebfb
fix: Align `SystemEpochInfoEvent` to Move
PhilippGackstatter 2b7204c
feat: Add todo for potentially emitting supply change
PhilippGackstatter 45b0c43
Merge remote-tracking branch 'origin/develop' into l1sc/issue-153-sta…
PhilippGackstatter e875682
fix: Rename stake subsidy allocation to funds to burn
PhilippGackstatter 33d47f1
Merge branch 'develop' into l1sc/issue-153-staking-reward-through-inf…
Dkwcs a9f7834
feat(iota-framework): non_refundable_storage_fee and leftover_staking…
Dkwcs b636d98
fix: Revert to validator target reward being total
PhilippGackstatter ceb0b38
fix: Update docs
PhilippGackstatter 5365161
fix: Mint correct amount of nanos in genesis PTB
PhilippGackstatter 22d3c09
fix: advance_epoch params and conservation check
PhilippGackstatter af21774
fix: Skip the authority conservation checks for now
PhilippGackstatter 46d16ca
feat: Rework genesis supply minting and burning
PhilippGackstatter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be an easier option instead of removing the
stake_subsidy
related stuff, just to configure it not to generate rewards?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we intend to reuse the stake subsidy fund at any point in the future. So I think removing it is the best option, otherwise it becomes technical debt immediately. Or am I missing your point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, we do not need it.
Removing this entity affects a lot of code and seems like it can be disabled, so I thought that it was better to remove it later as a separate task when we have inflation tests ready.
We also need to clean
GenesisCeremonyParameters
from the subsidy stuff.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, by now I already removed a lot of subsidy related stuff, but not all. If the current state works without removing more, we can remove the rest later - I already mentioned this in the PR description as a later task for which we should create issues.