feat(iota): add data_ingestion_dir to iota start command #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
iota-ci
added
dev-tools
Comment on lines
+766
to
+772
| if with_indexer.is_some() && data_ingestion_dir.is_none() { | ||
| data_ingestion_dir = Some(tempdir()?.into_path()) | ||
| } | ||
|
|
||
| #[cfg(feature = "indexer")] | ||
| if let Some(ref dir) = data_ingestion_dir { | ||
| swarm_builder = swarm_builder.with_data_ingestion_dir(dir.clone()); |
There was a problem hiding this comment.
Should we throw an error if the user tries to use both?
There was a problem hiding this comment.
I don't think so, why shouldn't it be fine to have both at the same time?
There was a problem hiding this comment.
It says they are incompatable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add data_ingestion_dir to iota start command so one can set the folder in which executed checkpoints are saved as files.
This is useful, among other things, for testing a custom local reader indexing setup with low overhead.
Porting over MystenLabs/sui#20472
Type of change
How the change has been tested
Running
cargo run --features=indexer start --force-regenesis --with-faucet --data-ingestion-dir "data-ingestion-dir" --with-indexercreated a folderdata-ingestion-dir/with the checkpoint files: