Fix get_all_balances returning zero objects count in fullnode #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iota-ci
added
infrastructure
tomxey
force-pushed
the
sc-platform/fix-get-all-balances-returning-zero-objects-count
branch
from
5974337 to
4ba1c82
Compare
muXxer
reviewed
Jan 16, 2025
| @@ -1367,6 +1367,15 @@ impl IndexStore { | |||
| }) | |||
| }) | |||
| .await | |||
| .map(|balances_map| { | |||
There was a problem hiding this comment.
I'm not sure I understand this part to 100%, but wouldn't that mean we never cache entries with 0 balance, and therefore with every lookup we have expensive DB lookups now?
There was a problem hiding this comment.
The filtering is done at the very end, so it's not affecting the process of reading from and filling the cache.
We are storing the 0 balance entries in cache just like before.
kodemartin
approved these changes
Jan 17, 2025
Comment on lines
+1370
to
+1377
| .map(|balances_map| { | ||
| Arc::new( | ||
| (*balances_map) | ||
| .clone() | ||
| .into_iter() | ||
| .filter(|(_, TotalBalance { num_coins, .. })| *num_coins > 0) | ||
| .collect::<HashMap<_, _>>(), | ||
| ) |
There was a problem hiding this comment.
Nit: It would save the reallocation, and reconstruction of the map
Suggested change
| .map(|balances_map| { | |
| Arc::new( | |
| (*balances_map) | |
| .clone() | |
| .into_iter() | |
| .filter(|(_, TotalBalance { num_coins, .. })| *num_coins > 0) | |
| .collect::<HashMap<_, _>>(), | |
| ) | |
| .map(|mut balances_map| { | |
| Arc::make_mut(&mut balances_map) | |
| .retain(|_, TotalBalance { num_coins, .. }| *num_coins > 0); | |
| balances_map |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Implement filtering of balances returned by
get_all_balancesto omit coins with zero objects count.The most probable root cause of the issue was described here: #4349 (comment)
Links to any relevant issues
#4349
Type of change
How the change has been tested
cargo test --package=iota-indexer --profile=simulator --features shared_test_runtimecargo nextest run --package=iota-json-rpc-testsChange checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.