Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(explorer): display only the top 10 validators in homepage #4575

Merged
merged 3 commits into from
Dec 20, 2024
Merged

feat(explorer): display only the top 10 validators in homepage #4575

merged 3 commits into from
Dec 20, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Dec 19, 2024

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Closes #4573

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@cpl121 cpl121 added tooling Issues related to the Tooling team explorer Issues related to the Explorer labels Dec 19, 2024
@cpl121 cpl121 requested a review from a team as a code owner December 19, 2024 16:22
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e7cd554

✅ Preview: https://rebased-explorer-bjaky3vhl-iota1.vercel.app

brancoder
brancoder approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsporn
Copy link
Member

Can we try to make Popular Packages and Top Validators spaced equally?

@alexsporn
Copy link
Member

Maybe by moving the View All button to the top right it can be aligned easier with the Popular Packages since that one has the filters on the top right.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 90bee59

✅ Preview: https://rebased-explorer-8quhsf5yr-iota1.vercel.app

@cpl121 cpl121 merged commit 37fdde5 into develop Dec 20, 2024
35 checks passed
@cpl121 cpl121 deleted the tooling-explorer/display-only-10-validators branch December 20, 2024 13:05
miker83z pushed a commit that referenced this pull request Dec 20, 2024
@cpl121 @miker83z
feat(explorer): display only the top 10 validators in homepage (#4575)
e3abbb5 
* feat(explorer): display only the top 10 validators in homepage

* fix(explorer): format

* fix(explorer): move View all button to the top in Top Validators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancoder brancoder brancoder approved these changes

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

Assignees
No one assigned
Labels
explorer Issues related to the Explorer tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display only the top 10 validators in homepage
4 participants
@cpl121 @alexsporn @panteleymonchuk @brancoder