fix(wallet-dashboard): other assets

[cpl121]

Description of change

Other assets in the dashboard should not contain Coins nor NFTs, it contains at least coins for now
Other assets should just open a new tab in the explorer

Links to any relevant issues

Closes #4572

Type of change

Choose a type of change, and delete any options that are not relevant.

• Bug fix (a non-breaking change which fixes an issue)
• Enhancement (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked that new and existing unit tests pass locally with my changes

[github-actions]

This pull request has been deployed to Vercel.

Latest commit: f62f401

✅ Preview: https://wallet-dashboard-bjjykixrs-iota1.vercel.app

[brancoder]

just a nit about code optimization and reverting code added in previous PR

[brancoder]

we simplified this code by removing visualAssets and otherAssets based on the comment in this PR > #4038 (comment)
with this PR we would be reverting back the changes

[cpl121]

That code was incorrect because the objects were always pushed to assets array
if (selectedCategory == AssetCategory.Visual) { if(hasDisplayData(asset)) { assets.push(asset.data); } } else if(selectedCategory == AssetCategory.Other) { assets.push(asset.data); }
I have added a Map to simplify the code, but also to be able to separate it into the 2 categories, take a look and tell me what you think

[github-actions]

This pull request has been deployed to Vercel.

Latest commit: 9b816ec

✅ Preview: https://wallet-dashboard-4gkgpiyw7-iota1.vercel.app