Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Fix feedback form UI #4549

Merged
merged 4 commits into from
Dec 19, 2024
Merged

fix(docs): Fix feedback form UI #4549

merged 4 commits into from
Dec 19, 2024

Conversation

vivekjain23
Copy link
Contributor

@vivekjain23 vivekjain23 commented Dec 18, 2024 •
edited
Loading

Description of change

This PR bring up the changes to fix the feedback form UI.

Links to any relevant issues

Fixes #4522

Type of change

  • Documentation Fix

How the change has been tested

Changes were built locally.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@vivekjain23 vivekjain23 added documentation Improvements or additions to documentation dx-documentation For TW or documentation related issues. dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx. devx Issues related to the DevX team labels Dec 18, 2024
@vivekjain23 vivekjain23 marked this pull request as ready for review December 18, 2024 14:10
@vivekjain23 vivekjain23 requested a review from a team as a code owner December 18, 2024 14:10
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora
Copy link
Contributor

@vivekjain23 , I think you added the wrong for the issue

@vivekjain23
Copy link
Contributor Author

@vivekjain23 , I think you added the wrong for the issue

Yup, my bad. Updated it just now.

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@vivekjain23 vivekjain23 merged commit 1bd64f9 into develop Dec 19, 2024
36 checks passed
@vivekjain23 vivekjain23 deleted the devx/fix-feedback-form branch December 19, 2024 13:32
miker83z pushed a commit that referenced this pull request Dec 20, 2024
@vivekjain23 @miker83z
fix(docs): Fix feedback form UI (#4549)
95910c0 
* Fix feedback form UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@Ginowine Ginowine Ginowine approved these changes

Assignees
No one assigned
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation dx-documentation For TW or documentation related issues. dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx.
Projects
Developer Experience
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix feedback form UI
3 participants
@vivekjain23 @lucas-tortora @Ginowine