Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iota-analytics-indexer] Add README.md #4470

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[iota-analytics-indexer] Add README.md #4470

wants to merge 2 commits into from

Conversation

tomxey
Copy link
Contributor

@tomxey tomxey commented Dec 12, 2024 •
edited
Loading

Description of change

Add README.md for iota-analytics-indexer

Links to any relevant issues

#3976

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Documentation Fix

How the change has been tested

N.A.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation

@iota-ci iota-ci added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 12, 2024
@tomxey tomxey self-assigned this Dec 12, 2024
@tomxey tomxey force-pushed the sc-platform/review-iota-analytics-indexer branch 7 times, most recently from c6b09cf to 687df7d Compare December 12, 2024 12:08
@tomxey tomxey force-pushed the sc-platform/review-iota-analytics-indexer branch from 687df7d to 9e109b0 Compare December 12, 2024 12:19
@tomxey tomxey marked this pull request as ready for review December 12, 2024 12:20
@tomxey tomxey requested a review from a team as a code owner December 12, 2024 12:20
@kodemartin
Copy link
Contributor

Had a first quick read:

  • I don't get what metrics are collected though? How does it compare to the indexer-analytical-worker?
  • Could you elaborate on the BigQuery/Snowflake schemas used?
  • What is BigQuery and Snowflake in the first place? It would be helpful to write a few things and provide references links for digging deeper.

@lzpap lzpap linked an issue Dec 12, 2024 that may be closed by this pull request
[iota-analytics-indexer]: Review application use cases and collected metrics #3976
Open
@tomxey
Fixing review remarks:
193811b 
 - Added more info about SnowFlake and BigQuery
 - Expanded a bit the comparison with iota-indexer
 - Added more info about schemas for exported data
@tomxey
Copy link
Contributor Author

tomxey commented Dec 17, 2024

Had a first quick read:

* I don't get what metrics are collected though? How does it compare to the `indexer-analytical-worker`?

* Could you elaborate on the `BigQuery/Snowflake` schemas used?

* What is `BigQuery` and `Snowflake` in the first place? It would be helpful to write a few things and provide references links for digging deeper.

@kodemartin Pushed changes that are addressing those remarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-rufi samuel-rufi Awaiting requested review from samuel-rufi

@kodemartin kodemartin Awaiting requested review from kodemartin

@sergiupopescu199 sergiupopescu199 Awaiting requested review from sergiupopescu199

At least 2 approving reviews are required to merge this pull request.

Assignees

@tomxey tomxey

Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iota-analytics-indexer]: Review application use cases and collected metrics
3 participants
@tomxey @kodemartin @iota-ci