Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devx): fix move.toml and build-test.mdx #4456

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

lucas-tortora
Copy link
Contributor

Description of change

Updated fist_package move.toml to use GH
Updated build_test.mdx to fix errors.

Links to any relevant issues

fixes #4462

Type of change

  • Documentation Fix

How the change has been tested

Docs and packages were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@lucas-tortora lucas-tortora requested a review from a team as a code owner December 11, 2024 15:38
@iota-ci iota-ci added the devx Issues related to the DevX team label Dec 11, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 11, 2024
@lucas-tortora lucas-tortora added the dx-documentation For TW or documentation related issues. label Dec 11, 2024
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

@vivekjain23 vivekjain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora merged commit 3befead into develop Dec 13, 2024
35 of 36 checks passed
@lucas-tortora lucas-tortora deleted the devx/update-getting-started-guide branch December 13, 2024 12:35
miker83z pushed a commit that referenced this pull request Dec 20, 2024
* fix(devx): fix move.toml and build-test.mdx

* dprint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation dx-documentation For TW or documentation related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs feedback: Move first_package test fails
4 participants