Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admonitions #4455

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Fix admonitions #4455

merged 3 commits into from
Dec 13, 2024

Conversation

Dr-Electron
Copy link
Contributor

Description of change

Updated the admonitions mentioned by Thibault after confirming it with the related teams

Links to any relevant issues

Fixes #4452.

Type of change

  • Documentation Fix

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Dr-Electron Dr-Electron requested a review from a team as a code owner December 11, 2024 15:21
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 11, 2024
@iota-ci iota-ci added the devx Issues related to the DevX team label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Dr-Electron Dr-Electron mentioned this pull request Dec 13, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Dr-Electron Dr-Electron mentioned this pull request Dec 13, 2024
Open
@Dr-Electron Dr-Electron merged commit d7b4ec1 into develop Dec 13, 2024
35 of 36 checks passed
@Dr-Electron Dr-Electron deleted the devx/fix-admonitions branch December 13, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex6323 Alex6323 Alex6323 left review comments

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@kodemartin kodemartin Awaiting requested review from kodemartin

Assignees
No one assigned
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check admonitions
5 participants
@Dr-Electron @thibault-martinez @Alex6323 @lucas-tortora @iota-ci