fix(CI): Fix move tests workflow and add additional tests that use examples #4429
+1,143
−1,084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaughterOfMars
requested review from
msarcev,
alexsporn,
thibault-martinez,
Dr-Electron and
a team
as code owners
iota-ci
added
dev-tools
thibault-martinez
approved these changes
Dec 18, 2024
Alex6323
approved these changes
Dec 18, 2024
kodemartin
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Hey @DaughterOfMars, looks good, but I reckon that mod example should be renamed to mod move. I expanded on the reasoning in a more specific comment.
kodemartin
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes a bug in
_move_tests.ymlwhich was broken by #2535 asunit_tests::was renamed totests::.Wraps several tests in an
examplemodule so that they can be specifically queried for in the move tests jobs.Adds a secondary job as some of the tests that use examples are simtests.
Updates the commands in move tests so that it selects all tests that use examples.
Links to any relevant issues
Closes #4120