Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(devx) - Edit nft marketplace example readme #4357

Conversation

lucas-tortora
Copy link
Contributor

Description of change

Edited the README file for https://github.com/iotaledger/iota/tree/sc-platform/Create-an-example-NFT-marketplace-using-the-Kiosk-framework/docs/examples/move/nft_marketplace

Type of change

  • Documentation Fix

How the change has been tested

Docs were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@lucas-tortora lucas-tortora requested a review from a team as a code owner December 4, 2024 15:02
@lucas-tortora lucas-tortora requested a review from Dkwcs December 4, 2024 15:03
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: d8cf9e2

✅ Preview: https://apps-ui-10l5ce6t5-iota1.vercel.app

Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: d8cf9e2

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-l4q1dolfg.vercel.app

Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: d8cf9e2

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-hv7y38j3e.vercel.app

Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: d8cf9e2

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-qlhj2ccnh.vercel.app

Copy link
Contributor

@Dkwcs Dkwcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vivekjain23 vivekjain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a build issue, the rest looks good to me.

@Dkwcs Dkwcs merged commit a9fe64e into sc-platform/Create-an-example-NFT-marketplace-using-the-Kiosk-framework Dec 5, 2024
32 of 34 checks passed
@Dkwcs Dkwcs deleted the devx/edit-nft-marketplace-readme branch December 5, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants