Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs) : Add validator requirements tab snippet. #4230

Merged

Conversation

vivekjain23
Copy link
Contributor

Description of change

This PR discusses the changes to create a validator requirements tab component in the document so we can use it elsewhere and update a single location.

Links to any relevant issues

Fixes #4096.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Changes were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@vivekjain23 vivekjain23 added documentation Improvements or additions to documentation dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx. devx Issues related to the DevX team labels Nov 26, 2024
@vivekjain23 vivekjain23 self-assigned this Nov 26, 2024
@vivekjain23 vivekjain23 requested a review from a team as a code owner November 26, 2024 07:01
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add it to https://docs.iota.org/operator/validator-config ?

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Vercel Preview Deployment is ready!

View Preview

@vivekjain23 vivekjain23 merged commit 9f50d1c into develop Dec 5, 2024
35 checks passed
@vivekjain23 vivekjain23 deleted the devx/create-validator-requirements-tab-component branch December 5, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create component for validator requirements
3 participants