Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs) : Fix navbar items UI #4155

Closed
wants to merge 10 commits into from
Closed

fix(docs) : Fix navbar items UI #4155

wants to merge 10 commits into from

Conversation

vivekjain23
Copy link
Contributor

Description of change

This PR bring up the changes to fix the navbar items UI. It removes TS SDK from the references directory.

Links to any relevant issues

fixes #4129.

Type of change

  • Documentation Fix

How the change has been tested

Changes were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@vivekjain23 vivekjain23 self-assigned this Nov 20, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 20, 2024
@lucas-tortora
Copy link
Contributor

@vivekjain23 , what's the status on this PR?

@iota-ci iota-ci added the devx Issues related to the DevX team label Dec 13, 2024
@vivekjain23 vivekjain23 marked this pull request as ready for review December 13, 2024 10:50
@vivekjain23 vivekjain23 requested review from a team as code owners December 13, 2024 10:50
@vivekjain23
Copy link
Contributor Author

@vivekjain23 , what's the status on this PR?

Had a blocker, regarding the client-redirect plugin, resolved it and now it is ready to review.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4b5f7c8

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-8a6o98vc5.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4b5f7c8

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-i9f4cd8in.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4b5f7c8

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-3h0kx6izw.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c25ca64

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-rkaq7knck.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c25ca64

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-ptvcdbhtt.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c25ca64

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-plsq20y1h.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8b54e5f

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-exwu6pvxb.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: be583ee

✅ Preview: https://apps-backend-2z9yd98el-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: be583ee

✅ Preview: https://rebased-explorer-nmd4rpu4n-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: be583ee

✅ Preview: https://wallet-dashboard-5k9s6m1d8-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 31ae952

✅ Preview: https://apps-backend-z24pgtewu-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 31ae952

✅ Preview: https://rebased-explorer-o2gr4obgg-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 31ae952

✅ Preview: https://wallet-dashboard-8huyojdp6-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 871d53a

✅ Preview: https://apps-backend-a9bz2l9q4-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 871d53a

✅ Preview: https://rebased-explorer-d44ppmenm-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 871d53a

✅ Preview: https://wallet-dashboard-ez598e6th-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@vivekjain23 vivekjain23 force-pushed the devx/fix-navbar-items-ui branch from 871d53a to dbe2c94 Compare December 20, 2024 14:07
@github-actions github-actions bot added the explorer Issues related to the Explorer label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@Ginowine Ginowine Ginowine approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@msarcev msarcev Awaiting requested review from msarcev msarcev is a code owner

@alexsporn alexsporn Awaiting requested review from alexsporn alexsporn is a code owner

@thibault-martinez thibault-martinez Awaiting requested review from thibault-martinez thibault-martinez is a code owner

@DaughterOfMars DaughterOfMars Awaiting requested review from DaughterOfMars DaughterOfMars is a code owner

@kodemartin kodemartin Awaiting requested review from kodemartin kodemartin is a code owner

@miker83z miker83z Awaiting requested review from miker83z miker83z is a code owner

Assignees

@vivekjain23 vivekjain23

Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation explorer Issues related to the Explorer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the navbar highlighting issue
6 participants
@vivekjain23 @lucas-tortora @begonaalvarezd @Ginowine @Dr-Electron @iota-ci