Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devx): Update images about iota and execution architecture #4031

Merged
merged 15 commits into from
Nov 15, 2024

Conversation

lucas-tortora
Copy link
Contributor

Description of change

Added light/dark theme svgs and image zoom.

Links to any relevant issues

fixes #4014

Type of change

  • Documentation Fix

How the change has been tested

Docs were built locally.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release notes

Added light/dark theme svgs

@lucas-tortora lucas-tortora requested a review from a team as a code owner November 12, 2024 20:29
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 12, 2024
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4c42743

✅ Preview: https://apps-ui-ml2r8ejdv-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4c42743

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-43y17rhnv.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4c42743

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-liukf79cr.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4c42743

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-8589e55nd.vercel.app

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Phyloiota
Copy link

I have one issue with the picture:
The storage deposit has a red arrow flow from "storage deposit" to "user". The Red arrow is defined a s a "burn" operation.
But that's not actually true - the storage deposit is not "burned back to the user" - it's given back to the user without burning.
Also, its not a "mint" operation to pay the storage fees - basically both arrows need a different color not associated with mint/burn, and maybe just call them "deposit" and "redeem"
And the Staking rewards are also not correctly displayed.

I made this one - maybe use it?

image

Tokenomic
Tokenomics

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

@vivekjain23 vivekjain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

docs/content/references/execution-architecture/adapter.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

@Ginowine Ginowine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b29d8d5

✅ Preview: https://apps-ui-np8wq77xs-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b29d8d5

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-plg3q4ly1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b29d8d5

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-g3ig4il1p.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b29d8d5

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-4gqlehu31.vercel.app

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora merged commit 42eda3f into develop Nov 15, 2024
33 of 34 checks passed
@lucas-tortora lucas-tortora deleted the devx/update-images-about-iota branch November 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update diagrams and images to use IOTA Wiki's draw.io
4 participants