Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix cli_tests made by #2574 #3970

Merged
merged 9 commits into from
Nov 9, 2024
Merged

fix(cli): fix cli_tests made by #2574 #3970

merged 9 commits into from
Nov 9, 2024

Conversation

salaheldinsoliman
Copy link
Contributor

Description of change

My pr #2574 caused some failures in cli_tests. The main problem was caused by marking emit as not required, while not wrapping it in an Option. So, clap assumed it to be required

Links to any relevant issues

fixes #3968

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

cli_tests ran locally

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Signed-off-by: salaheldinsoliman <[email protected]>
@salaheldinsoliman salaheldinsoliman requested a review from a team as a code owner November 8, 2024 15:14
@salaheldinsoliman salaheldinsoliman marked this pull request as draft November 8, 2024 15:35
@salaheldinsoliman salaheldinsoliman marked this pull request as ready for review November 8, 2024 17:05
@lzpap lzpap merged commit 1548a36 into develop Nov 9, 2024
38 of 40 checks passed
@lzpap lzpap deleted the devx/fix-cl-tests branch November 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken iota cli tests
3 participants