Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-dashboard): style select validator #3854

Closed
wants to merge 2 commits into from
Closed

feat(wallet-dashboard): style select validator #3854

wants to merge 2 commits into from

Conversation

panteleymonchuk
Copy link
Contributor

@panteleymonchuk panteleymonchuk commented Nov 1, 2024 •
edited
Loading

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Closes #3698
Depends on #3832

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Nov 1, 2024
@panteleymonchuk panteleymonchuk requested review from a team as code owners November 1, 2024 19:36
@begonaalvarezd begonaalvarezd changed the title feat(wallet-dashboard): select validator. feat(wallet-dashboard): syle select validator Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has been deployed to Vercel.

Latest commit: 7d16bd2

✅ Preview: https://apps-ui-fdedwsi2c-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has been deployed to Vercel.

Latest commit: 7d16bd2

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-p1ss0ilc6.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has been deployed to Vercel.

Latest commit: 7d16bd2

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-3zllb8ikb.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has been deployed to Vercel.

Latest commit: 7d16bd2

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-4tvsyb6s6.vercel.app

@panteleymonchuk panteleymonchuk changed the title feat(wallet-dashboard): syle select validator feat(wallet-dashboard): style select validator Nov 4, 2024
@panteleymonchuk panteleymonchuk linked an issue Nov 4, 2024 that may be closed by this pull request
Style staking flow select validator screen #3698
Closed
@panteleymonchuk panteleymonchuk force-pushed the tooling-dashboard/style-select-validator branch from 7d16bd2 to dc319da Compare November 7, 2024 19:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: dc319da

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-6z2hlrjpg.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This pull request has been deployed to Vercel.

Latest commit: dc319da

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-r225pz89g.vercel.app

brancoder
brancoder requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint failing in StartStaking.tsx 🙏

@panteleymonchuk panteleymonchuk force-pushed the tooling-dashboard/style-select-validator branch from dc319da to f7c2c6f Compare November 13, 2024 15:19
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f7c2c6f

✅ Preview: https://apps-ui-9qk34rg1s-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f7c2c6f

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-ghnty51lh.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f7c2c6f

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-8lkwv8i2g.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f7c2c6f

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-6fyoooxja.vercel.app

@panteleymonchuk
Copy link
Contributor Author

panteleymonchuk commented Nov 13, 2024 •
edited
Loading

For decrease dependencies, changes for this PR added in the #3832

All commnets fixed

@begonaalvarezd begonaalvarezd deleted the tooling-dashboard/style-select-validator branch December 3, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 Awaiting requested review from cpl121

@brancoder brancoder Awaiting requested review from brancoder

Assignees
No one assigned
Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style staking flow select validator screen
3 participants
@panteleymonchuk @brancoder @cpl121