fix(iota-framework): check already minted supply for CoinManager
#3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriyr
added
the
sc-platform
muXxer
reviewed
Nov 1, 2024
| // We should now have a Supply of 10. | ||
| assert!(wrapper.total_supply() == 10); | ||
|
|
||
| // Update the maximum supply that lower than the total supply, this should not be allowed. |
There was a problem hiding this comment.
Suggested change
| // Update the maximum supply that lower than the total supply, this should not be allowed. | |
| // Update the maximum supply to be lower than the total supply, this should not be allowed. |
| scenario.end(); | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
Suggested change
| #[test] | |
| #[test] |
| option::none(), | ||
| scenario.ctx(), | ||
| ); | ||
|
|
There was a problem hiding this comment.
Also in the test above there is this double newline, I guess we can remove it.
| @@ -161,10 +246,10 @@ module iota::coin_manager_tests { | |||
|
|
|||
lzpap
approved these changes
Nov 4, 2024
valeriyr
deleted the
sc-platform/issue-415-check-already-minted-supply
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The issue originally concerned the
capped_coinmodule.Although it has already been removed from the framework, the issue is still relevant to
CoinManager.The
capped_coinRust module was removed.Links to any relevant issues
fixes #415
Type of change
Choose a type of change, and delete any options that are not relevant.