Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iota-core): Remove incorrect AuthorityState ::state comment #3843

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

bingyanglin
Copy link
Contributor

Description of change

Remove the incorrect comment.

The TODO comment to remove the AuthorityState ::state was written in this Sui commit d6a9015 at Jan 27, 2024.
However, the AuthorityState ::state is then used in object_cache_reader and transaction_cache_reader in the later Sui Commit 6243a15 at May 17, 2024. In addition, the transaction_manager which is cloned from AuthorityState ::state is also used to call the enqueue_with_expected_effects_digest method.

Thus the AuthorityState::state should not be removed, and the incorrect TODO comment should be removed.

Links to any relevant issues

Part of #2092

Type of change

  • Enhancement

How the change has been tested

Ran the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin added the node Issues related to the Core Node team label Nov 1, 2024
@bingyanglin bingyanglin self-assigned this Nov 1, 2024
@bingyanglin bingyanglin requested review from a team as code owners November 1, 2024 06:41
@bingyanglin bingyanglin mentioned this pull request Nov 1, 2024
18 tasks
@bingyanglin bingyanglin changed the title Remove incorrect comment refactor(iota-core): Remove incorrect AuthorityState ::state comment Nov 1, 2024
@muXxer muXxer merged commit a871e60 into develop Nov 4, 2024
36 of 38 checks passed
@muXxer muXxer deleted the core-node/feat/correct-checkpoint-executor-comment branch November 4, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants