Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devx): fix broken images #3840

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix(devx): fix broken images #3840

merged 4 commits into from
Nov 6, 2024

Conversation

lucas-tortora
Copy link
Contributor

Description of change

  • Fixed broken favicon and wiki logo

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Documentation Fix

How the change has been tested

Docs were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@lucas-tortora lucas-tortora requested a review from a team as a code owner October 31, 2024 17:25
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@alexsporn alexsporn added the devx Issues related to the DevX team label Nov 1, 2024
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a broken image under Why IOTA, is there an asset for it?
image

Copy link
Contributor

@vivekjain23 vivekjain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IOTA Wiki logo at the Navbar is not rendered.
ss

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

@vivekjain23 vivekjain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lucas-tortora lucas-tortora merged commit 900a641 into develop Nov 6, 2024
32 checks passed
@lucas-tortora lucas-tortora deleted the devx/fix-broken-images branch November 6, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Issues related to the DevX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants