Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet-dashboard): style send entry screen #3807

Merged

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Oct 30, 2024

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Closes #3688

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

…op' of github.com:iotaledger/iota into tooling-dashboard/style-send-entry-screen
…op' of github.com:iotaledger/iota into tooling-dashboard/style-send-entry-screen
@alexsporn alexsporn added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Oct 31, 2024
@cpl121 cpl121 changed the title feat(wallet-dashboard): style send entry screen WIP feat(wallet-dashboard): style send entry screen Nov 7, 2024
@cpl121 cpl121 changed the title feat(wallet-dashboard): style send entry screen style send entry screen Nov 8, 2024
@cpl121 cpl121 marked this pull request as ready for review November 8, 2024 09:01
@cpl121 cpl121 requested review from a team as code owners November 8, 2024 09:01
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: d0ca55d

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-kyhb7dxjg.vercel.app

Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: d0ca55d

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-hyq4owdx2.vercel.app

Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: d0ca55d

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-428uia8g4.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting there, just an issue with formik in dashboard:

  1. click send
  2. click max button
    image

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b889904

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-mw47vicv4.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b889904

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-5ss2wybe6.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b889904

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-25hcn6oj6.vercel.app

@cpl121 cpl121 requested a review from brancoder November 19, 2024 15:33
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 6eca201

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-4p704tup6.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 6eca201

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-h11huicgh.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 6eca201

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-o13b8mnns.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🦝

Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small thing. Remove the default exports from the dashboard and core, and do export * in the index files.

Also, we should avoid exporting things that are not components from component files, and instead move them to other files if they are necessary to export. Just so we don't break HMR

@cpl121 cpl121 requested a review from VmMad November 20, 2024 10:45
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0f1b54c

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-7v83ak9rb.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0f1b54c

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-kdp7lfe4m.vercel.app

@marc2332
Copy link
Contributor

ci failing

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ec1f344

✅ Preview: https://apps-ui-diipk54ud-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ec1f344

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-6waji993x.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ec1f344

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-nlkviu5r4.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2104062

✅ Preview: https://apps-ui-p5kh3fma4-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2104062

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-1xogmbrx1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2104062

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-byxld1lyo.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2104062

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-qmr7c7rk0.vercel.app

Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpl121 cpl121 merged commit bacfda4 into tooling-epic/dashboard-styling Nov 20, 2024
32 of 33 checks passed
@cpl121 cpl121 deleted the tooling-dashboard/style-send-entry-screen branch November 20, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style send entry screen
7 participants