-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet-dashboard): style send entry screen #3807
feat(wallet-dashboard): style send entry screen #3807
Conversation
…op' of github.com:iotaledger/iota into tooling-dashboard/style-send-entry-screen
…op' of github.com:iotaledger/iota into tooling-dashboard/style-send-entry-screen
…op' of github.com:iotaledger/iota into tooling-dashboard/style-send-entry-screen
…op' of github.com:iotaledger/iota into tooling-dashboard/style-send-entry-screen
…hboard/style-send-entry-screen
…op' of github.com:iotaledger/iota into tooling-dashboard/style-send-entry-screen
This pull request has been deployed to Vercel. Latest commit: d0ca55d ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-kyhb7dxjg.vercel.app |
This pull request has been deployed to Vercel. Latest commit: d0ca55d ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-hyq4owdx2.vercel.app |
This pull request has been deployed to Vercel. Latest commit: d0ca55d ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-428uia8g4.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been deployed to Vercel. Latest commit: b889904 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-mw47vicv4.vercel.app |
This pull request has been deployed to Vercel. Latest commit: b889904 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-5ss2wybe6.vercel.app |
This pull request has been deployed to Vercel. Latest commit: b889904 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-25hcn6oj6.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 6eca201 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-4p704tup6.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 6eca201 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-h11huicgh.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 6eca201 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-o13b8mnns.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 🦝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small thing. Remove the default exports from the dashboard and core, and do export *
in the index files.
Also, we should avoid exporting things that are not components from component files, and instead move them to other files if they are necessary to export. Just so we don't break HMR
This pull request has been deployed to Vercel. Latest commit: 0f1b54c ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-7v83ak9rb.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 0f1b54c ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-kdp7lfe4m.vercel.app |
ci failing |
This pull request has been deployed to Vercel. Latest commit: ec1f344 ✅ Preview: https://apps-ui-diipk54ud-iota1.vercel.app |
This pull request has been deployed to Vercel. Latest commit: ec1f344 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-6waji993x.vercel.app |
This pull request has been deployed to Vercel. Latest commit: ec1f344 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-nlkviu5r4.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 2104062 ✅ Preview: https://apps-ui-p5kh3fma4-iota1.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 2104062 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-1xogmbrx1.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 2104062 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-byxld1lyo.vercel.app |
This pull request has been deployed to Vercel. Latest commit: 2104062 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-qmr7c7rk0.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bacfda4
into
tooling-epic/dashboard-styling
Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
Closes #3688
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.