Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iota-storage): Remove deprecated_get_transaction_checkpoint #3775

Closed
wants to merge 4 commits into from
Closed

refactor(iota-storage): Remove deprecated_get_transaction_checkpoint #3775

wants to merge 4 commits into from

Conversation

jkrvivian
Copy link
Contributor

Description of change

Remove deprecated_get_transaction_checkpoint from TransactionKeyValueStoreTrait and remove all the implementations.

Links to any relevant issues

Part of #2092

Type of change

  • Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have checked that new and existing unit tests pass locally with my changes

@jkrvivian jkrvivian added the node Issues related to the Core Node team label Oct 30, 2024
@jkrvivian jkrvivian self-assigned this Oct 30, 2024
@jkrvivian jkrvivian force-pushed the core-node/fix/remove-deptrecated-get-transaction-checkpoint branch from c396b52 to c0db5b2 Compare October 30, 2024 09:54
@jkrvivian jkrvivian marked this pull request as ready for review October 30, 2024 11:51
@jkrvivian jkrvivian requested review from a team as code owners October 30, 2024 11:51
@thibault-martinez thibault-martinez mentioned this pull request Oct 30, 2024
Closed
18 tasks
@jkrvivian jkrvivian force-pushed the core-node/fix/remove-deptrecated-get-transaction-checkpoint branch from c0db5b2 to 65e6df1 Compare October 31, 2024 12:13
@jkrvivian jkrvivian force-pushed the core-node/fix/remove-deptrecated-get-transaction-checkpoint branch from 65e6df1 to 46b052a Compare October 31, 2024 13:18
@alexsporn alexsporn changed the base branch from develop to core-node/fix/remove-deprecated-authority-code November 4, 2024 16:46
@muXxer
Merge branch 'core-node/fix/remove-deprecated-authority-code' of gith…
38843a2 
…ub.com:iotaledger/iota into core-node/fix/remove-deptrecated-get-transaction-checkpoint
@alexsporn alexsporn closed this Nov 4, 2024
@alexsporn alexsporn deleted the core-node/fix/remove-deptrecated-get-transaction-checkpoint branch November 4, 2024 16:50
@muXxer
Copy link
Contributor

muXxer commented Nov 4, 2024

duplicate of #3829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees

@jkrvivian jkrvivian

Labels
node Issues related to the Core Node team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkrvivian @muXxer @Thoralf-M @alexsporn @bingyanglin