Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apps-backend, tooling-ci): Add e2e tests to apps backend #3760

Merged
merged 14 commits into from
Nov 12, 2024
Merged

feat(apps-backend, tooling-ci): Add e2e tests to apps backend #3760

merged 14 commits into from
Nov 12, 2024

Conversation

panteleymonchuk
Copy link
Contributor

@panteleymonchuk panteleymonchuk commented Oct 29, 2024 •
edited
Loading

Closes #3582

@panteleymonchuk panteleymonchuk added tooling Issues related to the Tooling team apps-backend Issues related to the Apps Backend labels Oct 29, 2024
@panteleymonchuk panteleymonchuk linked an issue Oct 29, 2024 that may be closed by this pull request
Add e2e tests to apps backend #3582
Closed
@panteleymonchuk panteleymonchuk force-pushed the tooling-apps-backend/e2e-test-check-healthy branch from 73a2896 to 3f1e45c Compare October 29, 2024 13:34
@panteleymonchuk panteleymonchuk force-pushed the tooling-apps-backend/e2e-test-check-healthy branch from 6a3d85c to ea05439 Compare October 29, 2024 17:22
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ea05439

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-67f40uyr3.vercel.app

@panteleymonchuk panteleymonchuk changed the title Tooling-apps-backend/e2e-test-check-healthy Add e2e tests to apps backend Oct 29, 2024
@panteleymonchuk panteleymonchuk changed the title Add e2e tests to apps backend feat(apps-backend) Add e2e tests to apps backend Oct 29, 2024
@panteleymonchuk panteleymonchuk marked this pull request as ready for review October 30, 2024 14:08
thibault-martinez
thibault-martinez approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow LGTM

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e4bfb6f

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-j08vklzwb.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f5750b4

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-6uiajhxj7.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 21eb409

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-2s5s3xrit.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1cb347f

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9qg69xrb1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c088463

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-qoulriw3v.vercel.app

msarcev
msarcev requested changes Nov 5, 2024
View reviewed changes
.github/workflows/apps_backend_deploy.yml Outdated Show resolved Hide resolved
@panteleymonchuk panteleymonchuk changed the title feat(apps-backend) Add e2e tests to apps backend feat(apps-backend, tooling-ci) Add e2e tests to apps backend Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This pull request has been deployed to Vercel.

Latest commit: 9ee99fc

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9ihzeszl6.vercel.app

msarcev
msarcev reviewed Nov 6, 2024
View reviewed changes
.github/workflows/_e2e.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 64886e3

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-sfhkv9mle.vercel.app

@begonaalvarezd begonaalvarezd changed the title feat(apps-backend, tooling-ci) Add e2e tests to apps backend feat(apps-backend, tooling-ci): Add e2e tests to apps backend Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: abada2f

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-aabaox10t.vercel.app

@msarcev msarcev merged commit a7d4447 into develop Nov 12, 2024
39 of 40 checks passed
@msarcev msarcev deleted the tooling-apps-backend/e2e-test-check-healthy branch November 12, 2024 11:40
begonaalvarezd added a commit that referenced this pull request Nov 12, 2024
@panteleymonchuk @msarcev @begonaalvarezd
feat(apps-backend, tooling-ci): Add e2e tests to apps backend (#3760)
f79630d 
* feat(apps-backend): add e2e tests.

* feat(apps-backend): add e2e tests to CI for testing.

* feat(apps-backend): move e2e tests to another config.

* feat(apps-backend): revert hierarchy.

* feat(apps-backend): remove DEPLOY_URL

* feat(apps-backend): remove DEPLOY_URL from e2e test

* feat(tooling-ci): move e2e tests for apps-backend to e2e.yml

* feat(apps-backend): Run apps-backend e2e tests conditionally on apps-backend changes

* feat(apps-backend): Run apps-backend e2e tests also on merge to develop

---------

Co-authored-by: Mario Sarcevic <[email protected]>
Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 left review comments

@msarcev msarcev msarcev approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@alexsporn alexsporn Awaiting requested review from alexsporn alexsporn is a code owner

@DaughterOfMars DaughterOfMars Awaiting requested review from DaughterOfMars DaughterOfMars is a code owner

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron Dr-Electron is a code owner

Assignees
No one assigned
Labels
apps-backend Issues related to the Apps Backend tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e tests to apps backend
5 participants
@panteleymonchuk @thibault-martinez @begonaalvarezd @msarcev @marc2332