New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Indexer): Use dedicated keypairs for Governance API tests #3745

Merged

samuel-rufi merged 2 commits into sc-platform/indexer-new-rpc-tests from l1sc/infra/governance-rpc-tests

Oct 29, 2024

Member

samuel-rufi commented Oct 29, 2024 •

edited

Loading

Description of change

In order to avoid potential conflicts with other indexer tests (that rely on the shared test cluster addresses) dedicated keypairs to create objects should be used. Furthermore this PR considers epoch progression from other tests and adjusts the tests accordingly.

Links to any relevant issues

Fixes #3738

Type of change

Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

RUST_TEST_THREADS=1 cargo test --features shared_test_runtime --test rpc-tests -- --nocapture

Change checklist

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes


          refactor: use dedicated keypairs and consider epoch progression from …

136d05f

…other tests

samuel-rufi self-assigned this

samuel-rufi requested a review from a team as a code owner

October 29, 2024 10:51

Contributor

github-actions bot commented Oct 29, 2024

This pull request has been deployed to Vercel.

Latest commit: 136d05f

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-k2bxzxo7r.vercel.app

Contributor

github-actions bot commented Oct 29, 2024

This pull request has been deployed to Vercel.

Latest commit: 136d05f

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-cw4339fel.vercel.app

Contributor

github-actions bot commented Oct 29, 2024

This pull request has been deployed to Vercel.

Latest commit: 136d05f

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-oghsb4v18.vercel.app

Contributor

github-actions bot commented Oct 29, 2024

This pull request has been deployed to Vercel.

Latest commit: 136d05f

✅ Preview: https://apps-ui-pewxt41sr-iota1.vercel.app

samuel-rufi changed the title ~~Use dedicated keypairs for Indexer Governance API tests~~ (Indexer): Use dedicated keypairs for Governance API tests

tomxey reviewed

View reviewed changes

crates/iota-indexer/tests/rpc-tests/governance_api.rs Outdated Show resolved Hide resolved

alexsporn added the infrastructure label


          refactor: remove unnecessary gas_price * 2

c9cf125

Contributor

github-actions bot commented Oct 29, 2024

This pull request has been deployed to Vercel.

Latest commit: c9cf125

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-d3l0wljqw.vercel.app

Contributor

github-actions bot commented Oct 29, 2024

This pull request has been deployed to Vercel.

Latest commit: c9cf125

✅ Preview: https://apps-ui-c4pcnbn9r-iota1.vercel.app

Contributor

github-actions bot commented Oct 29, 2024

This pull request has been deployed to Vercel.

Latest commit: c9cf125

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-98suhnvin.vercel.app

samuel-rufi requested review from sergiupopescu199 and tomxey

October 29, 2024 11:45

tomxey approved these changes

View reviewed changes

Contributor

tomxey left a comment

lgtm 🍉

Contributor

github-actions bot commented Oct 29, 2024

This pull request has been deployed to Vercel.

Latest commit: c9cf125

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-fqyyrfhmk.vercel.app

sergiupopescu199 approved these changes

View reviewed changes

Contributor

sergiupopescu199 left a comment

lgtm ✨

samuel-rufi merged commit 12d6f02 into sc-platform/indexer-new-rpc-tests

25 of 27 checks passed

samuel-rufi deleted the l1sc/infra/governance-rpc-tests branch

October 29, 2024 11:47

sergiupopescu199 pushed a commit that referenced this pull request


          (Indexer): Use dedicated keypairs for Governance API tests (#3745)

967ea66

* refactor: use dedicated keypairs and consider epoch progression from other tests

* refactor: remove unnecessary gas_price * 2

sergiupopescu199 pushed a commit that referenced this pull request


          (Indexer): Use dedicated keypairs for Governance API tests (#3745)

ea64d0a

* refactor: use dedicated keypairs and consider epoch progression from other tests

* refactor: remove unnecessary gas_price * 2

sergiupopescu199 pushed a commit that referenced this pull request


          (Indexer): Use dedicated keypairs for Governance API tests (#3745)

a5f3e2d

* refactor: use dedicated keypairs and consider epoch progression from other tests

* refactor: remove unnecessary gas_price * 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels