fix(move-stackless-bytecode): Total ordering in deriving the Move func call graph #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
external-crates/move/crates/move-stackless-bytecode/src/function_target_pipeline.rs
Outdated
Show resolved
Hide resolved
miker83z
force-pushed
the
fix/external-crates/move/rust-ordering
branch
from
3615cd2 to
36d3db2
Compare
|
This pull request has been deployed to Vercel. Latest commit: 36d3db2 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-kpevtuaqg.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 36d3db2 ✅ Preview: https://apps-ui-fj19bsdnd-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 36d3db2 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-2z2hfkwe2.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 36d3db2 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-fue0w6rsx.vercel.app |
thibault-martinez
approved these changes
Oct 29, 2024
miker83z
requested review from
muXxer,
msarcev,
alexsporn,
DaughterOfMars,
fijter,
Dr-Electron and
a team
as code owners
miker83z
force-pushed
the
fix/external-crates/move/rust-ordering
branch
from
36d3db2 to
0c37147
Compare
valeriyr
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
rust 1.81 checks at runtime user-provided comparison functions that do not correctly implement a total order. This was the case in
move-stackless-bytecodeand was fixed upstream.rust 1.81 PR is #3705
Type of change
How the change has been tested
cargo nextest run -p move-stackless-bytecodeChange checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.