Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(iota-indexer): Add tests for CoinApi #3580

Merged
merged 7 commits into from
Oct 30, 2024
Merged

test(iota-indexer): Add tests for CoinApi #3580

merged 7 commits into from
Oct 30, 2024

Conversation

tomxey
Copy link
Contributor

@tomxey tomxey commented Oct 23, 2024 •
edited
Loading

Description of change

Add indexer tests for CoinApi

The PR is rebased on top of #3600 until it's merged.

Links to any relevant issues

fixes #2196

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

cargo test -j2 --profile simulator --features shared_test_runtime --test rpc-tests

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@tomxey tomxey self-assigned this Oct 23, 2024
@tomxey tomxey changed the base branch from develop to sc-platform/indexer-new-rpc-tests October 23, 2024 10:02
@tomxey tomxey force-pushed the sc-platform/coin-api-tests-for-iota-indexer branch from 2d8d114 to 65a621e Compare October 23, 2024 12:53
@alexsporn alexsporn added the infrastructure Issues related to the Infrastructure Team label Oct 23, 2024
@tomxey tomxey force-pushed the sc-platform/coin-api-tests-for-iota-indexer branch from 65a621e to a949a1e Compare October 24, 2024 11:56
@tomxey tomxey changed the base branch from sc-platform/indexer-new-rpc-tests to l1sc/infra/indexer-rpc-tests October 24, 2024 11:57
@tomxey tomxey force-pushed the sc-platform/coin-api-tests-for-iota-indexer branch from a949a1e to 1e8677a Compare October 24, 2024 13:31
@tomxey tomxey marked this pull request as ready for review October 24, 2024 13:34
@tomxey tomxey requested a review from a team as a code owner October 24, 2024 13:34
@tomxey tomxey force-pushed the sc-platform/coin-api-tests-for-iota-indexer branch from 1e8677a to df6b53c Compare October 28, 2024 11:35
@tomxey tomxey requested a review from samuel-rufi October 28, 2024 11:37
@samuel-rufi samuel-rufi force-pushed the l1sc/infra/indexer-rpc-tests branch from f18db88 to a372460 Compare October 28, 2024 14:56
@samuel-rufi samuel-rufi requested review from a team as code owners October 28, 2024 14:56
sergiupopescu199
sergiupopescu199 reviewed Oct 28, 2024
View reviewed changes
crates/iota-indexer/tests/rpc-tests/coin_api.rs Outdated Show resolved Hide resolved
crates/iota-indexer/tests/rpc-tests/coin_api.rs Outdated Show resolved Hide resolved
crates/iota-indexer/tests/rpc-tests/coin_api.rs Outdated Show resolved Hide resolved
crates/iota-indexer/tests/rpc-tests/coin_api.rs Outdated Show resolved Hide resolved
crates/iota-indexer/tests/rpc-tests/coin_api.rs Outdated Show resolved Hide resolved
crates/iota-indexer/tests/rpc-tests/coin_api.rs Outdated Show resolved Hide resolved
crates/iota-indexer/tests/rpc-tests/coin_api.rs Outdated Show resolved Hide resolved
crates/iota-indexer/tests/rpc-tests/coin_api.rs Outdated Show resolved Hide resolved
Base automatically changed from l1sc/infra/indexer-rpc-tests to sc-platform/indexer-new-rpc-tests October 28, 2024 16:05
@tomxey tomxey force-pushed the sc-platform/coin-api-tests-for-iota-indexer branch from df6b53c to 82ce3a2 Compare October 29, 2024 11:01
@tomxey tomxey requested review from sergiupopescu199 and DaughterOfMars and removed request for a team October 29, 2024 11:03
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 82ce3a2

✅ Preview: https://apps-ui-hestrouh0-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 82ce3a2

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-3il4meq0k.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 82ce3a2

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-1k0dytmnv.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 82ce3a2

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-oudi579mt.vercel.app

samuel-rufi
samuel-rufi approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@samuel-rufi samuel-rufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tomxey the PR looks great. Please see and fix the clippy CI job which is failing before merging the PR.

sergiupopescu199
sergiupopescu199 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@sergiupopescu199 sergiupopescu199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm✨

Just the comment @samuel-rufi left #3580 (review)

@tomxey tomxey force-pushed the sc-platform/coin-api-tests-for-iota-indexer branch from 82ce3a2 to 4631c30 Compare October 30, 2024 10:26
@tomxey
Copy link
Contributor Author

tomxey commented Oct 30, 2024

Fixed clippy 4631c30 @samuel-rufi @sergiupopescu199

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4631c30

✅ Preview: https://apps-ui-1fxlcdpwe-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4631c30

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-6fy0sxjs9.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4631c30

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-jp7zbnik8.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4631c30

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-fivdu1ljw.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2dbde5

✅ Preview: https://apps-ui-4vttoraot-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2dbde5

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-7au3q739a.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2dbde5

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-30oliv10f.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2dbde5

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-jxsz9cjxk.vercel.app

@tomxey tomxey merged commit f1935f4 into sc-platform/indexer-new-rpc-tests Oct 30, 2024
33 of 39 checks passed
@tomxey tomxey deleted the sc-platform/coin-api-tests-for-iota-indexer branch October 30, 2024 11:02
sergiupopescu199 pushed a commit that referenced this pull request Oct 31, 2024
@tomxey @sergiupopescu199
test(iota-indexer): Add tests for CoinApi (#3580)
86cb775 
* feat(iota-indexer): Add tests for CoinApi

* Simplify `once_prepare_addr_with_iota_and_custom_coins`, reorder modules in main.rs

* Fixes after rebase

* Change return type of `once_prepare_addr_with_iota_and_custom_coins`

* Rename helper test functions

* Fix clippy

* Fix clippy
sergiupopescu199 pushed a commit that referenced this pull request Oct 31, 2024
@tomxey @sergiupopescu199
test(iota-indexer): Add tests for CoinApi (#3580)
eb664e5 
* feat(iota-indexer): Add tests for CoinApi

* Simplify `once_prepare_addr_with_iota_and_custom_coins`, reorder modules in main.rs

* Fixes after rebase

* Change return type of `once_prepare_addr_with_iota_and_custom_coins`

* Rename helper test functions

* Fix clippy

* Fix clippy
sergiupopescu199 pushed a commit that referenced this pull request Oct 31, 2024
@tomxey @sergiupopescu199
test(iota-indexer): Add tests for CoinApi (#3580)
0682515 
* feat(iota-indexer): Add tests for CoinApi

* Simplify `once_prepare_addr_with_iota_and_custom_coins`, reorder modules in main.rs

* Fixes after rebase

* Change return type of `once_prepare_addr_with_iota_and_custom_coins`

* Rename helper test functions

* Fix clippy

* Fix clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiupopescu199 sergiupopescu199 sergiupopescu199 approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@kodemartin kodemartin Awaiting requested review from kodemartin

@DaughterOfMars DaughterOfMars Awaiting requested review from DaughterOfMars

Assignees

@tomxey tomxey

Labels
infrastructure Issues related to the Infrastructure Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iota-indexer]: Add tests for CoinApi
5 participants
@tomxey @samuel-rufi @DaughterOfMars @sergiupopescu199 @alexsporn