Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to connect IOTA wallet #3204

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Add button to connect IOTA wallet #3204

wants to merge 7 commits into from

Conversation

Dr-Electron
Copy link
Contributor

@Dr-Electron Dr-Electron commented Oct 10, 2024 •
edited by vivekjain23
Loading

Description of change

Add Connect Wallet Button to the top right

Links to any relevant issues

Fixes #3203

Type of change

  • Documentation Enhancement

How the change has been tested

Tested locally

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Dr-Electron
Copy link
Contributor Author

I should probably also update the interactive components in the ts references now as it simplifies them a lot

@Dr-Electron Dr-Electron marked this pull request as ready for review October 10, 2024 23:01
@Dr-Electron Dr-Electron requested a review from a team as a code owner October 10, 2024 23:01
@Dr-Electron Dr-Electron marked this pull request as draft October 10, 2024 23:01
@Dr-Electron
Copy link
Contributor Author

Open questions:

  • Is there a way to pass props to the global provider? For example the autoconnect option for the wallet provider? Or do we need to enable it globally which could be annoying for users I guess 🤔
  • I still didn't figure out what accounts exactly are. I thought it's just like different addresses on a single mnemonic. But although I have two it doesn't really work with the interactive components. Are accounts really two different mnemonics?

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Dr-Electron Dr-Electron marked this pull request as ready for review October 11, 2024 11:56
@Dr-Electron Dr-Electron requested a review from a team October 11, 2024 11:56
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

vivekjain23
vivekjain23 reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@vivekjain23 vivekjain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Button's styles in Modal should be the same as we did ConnectButton.mdx

@vivekjain23
Copy link
Contributor

I think we could adjust the height of the connect button and make it less since it is looking a little off when connected and it is colliding with the search bar on smaller screens which could be fixed as well.
connect-button-nav

@vivekjain23
Copy link
Contributor

The code is looking good to me 😄

@alexsporn alexsporn added the devx Issues related to the DevX team label Oct 23, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Dr-Electron
Copy link
Contributor Author

The Button's styles in Modal should be the same as we did ConnectButton.mdx

I'm just using the defaults here. I think everyone can just use that code and adapt to their needs with additional theming and stuff

@lucas-tortora
Copy link
Contributor

Open questions:

  • I still didn't figure out what accounts exactly are. I thought it's just like different addresses on a single mnemonic. But although I have two it doesn't really work with the interactive components. Are accounts really two different mnemonics?

If I understood correctly, you can have multiple accounts(addresses) per profile (mnemonic, seed, private key, ledger). However, I seem to only be able to connect the "main" account in the useAccounts page.

@Ginowine
Copy link
Contributor

Could we change the background color of the "Install Wallet Extension" button to something darker? Currently, it overlaps with the content color, making it hard to read. Also, could we adjust its positioning slightly lower, as it currently covers some text on the card?

Screenshot 2024-11-12 at 15 52 31

@lucas-tortora
Copy link
Contributor

@Dr-Electron , could you resolve the conflicts?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekjain23 vivekjain23 vivekjain23 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task(docs)]: Prepare docs for interactive content by adding Connect Wallet button
5 participants
@Dr-Electron @vivekjain23 @lucas-tortora @Ginowine @alexsporn