feat(iota-json-rpc-api): Restore explorer metric endpoints

[samuel-rufi]

Description of change

Restores the explorer metric endpoints.

Links to any relevant issues

Fixes #1619

Dependencies

• [Task (Infrastructure)]: Restore metrics schema tables #1848

How the change has been tested

• I have run the docker-compose setup and tested the RPC endpoints with curl.

Try it yourself:

cd docker/pg-services-local
docker compose build
docker compose up -d

curl -s localhost:9005 --header 'Content-Type: application/json' --data '{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "iotax_getEpochMetrics",
  "params": []
}' | json_pp

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

[kodemartin]

Good job @samuel-rufi! Left a few comments and suggestions of non-critical nature nevertheless.

[kodemartin]

One more thing @samuel-rufi: I suggest changing the target branch into a new update-rpc-indexer-metrics (branched off from `develop) so that we stage all the related changes together, and coordinate with the tooling team (cc @begonaalvarezd, @marc2332, @msarcev )

In this context please also regenerate the openrpc.json in iota-open-rpc.

[kodemartin]

lgtm 🌸

[kodemartin]

I think the scopes of processors and handlers overlap after all, creating confusion on what should be where. Handlers process data, as well as processors in a way.

We should care of making this less ambiguous. Therefore I think it would be plausible to consolidate everything into a single module (handlers or processors), remove any suffixes/prefixes handlers or processors and classify between metrics in a nested module (what is now in the processors module except for the ObjectSnapshotProcessor) and the rest.

Nevertheless, this is a refactoring task that should not be part of the testnet milestone. Will create an issue accordingly.

[kodemartin]

#1958

[sergiupopescu199]

lgtm 🚀

[tomxey]

lgtm

[marc2332]

One more thing @samuel-rufi: I suggest changing the target branch into a new update-rpc-indexer-metrics (branched off from `develop) so that we stage all the related changes together, and coordinate with the tooling team (cc @begonaalvarezd, @marc2332, @msarcev )

In this context please also regenerate the openrpc.json in iota-open-rpc.

Any idea why this never returns anything? What am I issing?

[samuel-rufi]

@marc2332 the endpoint works in batches - it waits for enough checkpoints to calculate the metrics. The threshold default value is currently set as ADDRESS_PROCESSOR_BATCH_SIZE: usize = 80000;. However you can override this value if you like for example by adding - ADDRESS_PROCESSOR_BATCH_SIZE=100 to the indexer-analytics environment in the docker-compose. Make sure you re-create the container (e.g. docker-compose up -d --force-recreate) so that it includes your env variable.

curl -s localhost:9005 --header 'Content-Type: application/json' --data '{ "jsonrpc": "2.0", "id": 1, "method": "iotax_getAllEpochAddressMetrics", "params": [] }' | json_pp
{
   "id" : 1,
   "jsonrpc" : "2.0",
   "result" : [
      {
         "checkpoint" : 126,
         "cumulativeActiveAddresses" : 1,
         "cumulativeAddresses" : 412,
         "dailyActiveAddresses" : 1,
         "epoch" : 0,
         "timestampMs" : 1724673353380
      }
   ]
}