-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(wallet): improve component imports #1743
refactor(wallet): improve component imports #1743
Conversation
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just submitting a quick review before this PR grows bigger 🙏🏼
The original issue was open just to create an index for components which is missing and update those imports so you can import like import { CompA, CompB, ...} from blabla
instead of having 1 line per component like now.
I would not get into refactoring more imports for now, refactoring imports can escalate a lot, lets try to narrow the task to the only refactor described in the issue 🙏🏼
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…/improve-components-imports # Conflicts: # apps/wallet/src/ui/app/components/accounts/ImportPrivateKeyForm.tsx # apps/wallet/src/ui/app/components/accounts/ImportRecoveryPhraseForm.tsx # apps/wallet/src/ui/app/pages/accounts/ImportPassphrasePage.tsx # apps/wallet/src/ui/app/pages/accounts/ImportPrivateKeyPage.tsx # apps/wallet/src/ui/app/pages/accounts/ProtectAccountPage.tsx # apps/wallet/src/ui/app/pages/approval-request/transaction-request/index.tsx # apps/wallet/src/ui/app/shared/forms/FormField.tsx
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about imports like import { Button } from '../../../shared/ButtonUI';
?
it seems that we could do it in another PR, 121 files are enough for this one I think |
The task can't be closed then. Or a new one needs to be opened. Still, I would just do it in this PR, up to you @panteleymonchuk I guess |
I calculated only ~9 places with ButtonUI imports as relative path. |
Seems like we have a different understanding about the task, but it doesn't matter as I am not the one doing it 😄 Let's leave the changes related to shared to another task 💯 |
…/improve-components-imports # Conflicts: # apps/wallet/src/ui/app/pages/accounts/ImportSeedPage.tsx
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…/improve-components-imports # Conflicts: # apps/wallet/src/ui/app/pages/home/apps/index.tsx
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…rove-components-imports
* feat(wallet): Improve component imports. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * feat(wallet): improve imports. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * feat(wallet): revert not '_component' imports. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * feat(wallet): Change import to '_components'. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * feat(wallet): Change import to '_components'. Update after merge. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * feat(wallet): Update imports after merge develop. Fix PR comments. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * feat(wallet): Fixes after merge. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * fix: import --------- Signed-off-by: Eugene Panteleymonchuk <[email protected]> Co-authored-by: Mario <[email protected]> Co-authored-by: Begoña Alvarez <[email protected]>
Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
Closes #1704
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.