chore(CI): Add unused dependencies check #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaughterOfMars
requested review from
msarcev,
alexsporn,
thibault-martinez,
fijter,
Dr-Electron and
a team
as code owners
Thoralf-M
reviewed
Aug 12, 2024
|
There are no false positives to allow at all? |
not that I know of |
|
This PR is removing 23 dependencies from a complete compilation :) |
1 task
thibault-martinez
requested changes
Aug 13, 2024
thibault-martinez
approved these changes
Aug 14, 2024
miker83z
approved these changes
Aug 14, 2024
sergiupopescu199
approved these changes
Aug 15, 2024
|
please wait for CI to be done to merge |
bingyanglin
pushed a commit
that referenced
this pull request
Aug 19, 2024
* chore(CI): Add unused dependencies check * comment * use flags matrix * Add a comment to force workflow run * fix duplicate flags and add to external * remove unused dependencies * Remove more unused dependencies * More ignores * do external udeps * lock file * fix doc tests * fix mysten-common * revert doc * a few more unused deps * external * merge methods * review --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* chore(CI): Add unused dependencies check * comment * use flags matrix * Add a comment to force workflow run * fix duplicate flags and add to external * remove unused dependencies * Remove more unused dependencies * More ignores * do external udeps * lock file * fix doc tests * fix mysten-common * revert doc * a few more unused deps * external * merge methods * review --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* chore(CI): Add unused dependencies check * comment * use flags matrix * Add a comment to force workflow run * fix duplicate flags and add to external * remove unused dependencies * Remove more unused dependencies * More ignores * do external udeps * lock file * fix doc tests * fix mysten-common * revert doc * a few more unused deps * external * merge methods * review --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* chore(CI): Add unused dependencies check * comment * use flags matrix * Add a comment to force workflow run * fix duplicate flags and add to external * remove unused dependencies * Remove more unused dependencies * More ignores * do external udeps * lock file * fix doc tests * fix mysten-common * revert doc * a few more unused deps * external * merge methods * review --------- Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds unused dependency checks. These are per-crate like tests as it requires building.
Links to any relevant issues
Closes #1664