Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Tokenomics #1726

Merged
merged 21 commits into from
Aug 27, 2024
Merged

docs: Tokenomics #1726

merged 21 commits into from
Aug 27, 2024

Conversation

cyberphysic4l
Copy link
Contributor

Description of change

Review of the tokenomics-related docs by the tokenomics taskforce (@cyberphysic4l, @vekkiokonio and @oliviasaa)

Links to any relevant issues

#1407

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Documentation Fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somehow missing the notion of the rewards threshold from the new figure. Maybe we could have the computation fees arrow merge with the staking rewards arrow and visually represent somehow that what comes out of these two is always the constant reward which goes to delegators and validators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we have an arrow from computation fees to the rewards it is actually misleading because it implies that the amount of computation fees has an effect on the staking rewards. The way it has been implemented, the staking rewards are independent of the computation rewards, so I think this is the clearest way to represent it. In reality, we don't burn the entire fees and mint the entire reward, we take the difference and mint/burn accordingly, but that is an implementation detail imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually thought we were going to do it differently tbh, but I changed the figure from what we had in the tokenomics report because the arrow from computation fees to the reward bucker was essentially removed in the implementation. I thought we were going to have a "tip" component of the fee which would go to the validators as a prioritisation mechanism, rather than being burned, so this would increase their overall reward, and be more like the diagram in the tokenomics report with an arrow from fees to rewards.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with Andrew on his explanation. The implementation does not technically burn the fees, but in practice what we are doing is mimicking fee burning (which is what Andrew drew in the figure). I think merging those arrows will make it difficult for the reader to get what we do in practice, unless we make the figure super complete (which IMO is unnecessary, given that Andrew already drew something quite clean and clear)

@PhilippGackstatter
Copy link

Would you mind including an update to the rewards section in operator/validator-config#staking-rewards in this PR since it is closely related? Thanks 🙏

@oliviasaa oliviasaa marked this pull request as ready for review August 14, 2024 08:54
@oliviasaa oliviasaa requested a review from a team as a code owner August 14, 2024 08:54
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

* feat(docs): gas-in-iota.mdx was corrected

* fix(docs): review comments were corrected

* fix(docs): review comments were fixed
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora mentioned this pull request Aug 14, 2024
6 tasks
Copy link

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update to the operator section.

Edit: Btw, when merging this, use "Squash and merge" instead of just "Merge".

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me. Can we resolve discussion if we think they are "done"?

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lzpap lzpap merged commit b6e3b7e into develop Aug 27, 2024
24 checks passed
@lzpap lzpap deleted the docs/tokenomics branch August 27, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants