Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): rebrand home - update coin #1718

Merged
merged 29 commits into from
Aug 14, 2024
Merged

feat(wallet): rebrand home - update coin #1718

merged 29 commits into from
Aug 14, 2024

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #1673

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda self-assigned this Aug 8, 2024
@evavirseda evavirseda added the tooling Issues related to the Tooling team label Aug 8, 2024
@evavirseda evavirseda marked this pull request as ready for review August 12, 2024 09:16
@evavirseda evavirseda requested review from a team as code owners August 12, 2024 09:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 745ff80

✅ Preview: https://apps-ui-80xcymv7m-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c3b6181

✅ Preview: https://apps-ui-pakij6dts-iota1.vercel.app

@evavirseda evavirseda requested a review from marc2332 August 13, 2024 13:53
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9348451

✅ Preview: https://apps-ui-84d7tyd58-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 87e87ea

✅ Preview: https://apps-ui-ckh4hscoo-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b364086

✅ Preview: https://apps-ui-hh8igux8p-iota1.vercel.app

marc2332
marc2332 requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

apps/wallet/src/ui/app/components/coin-icon/index.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/home/tokens/TokensDetails.tsx Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from marc2332 August 14, 2024 08:33
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8d07e76

✅ Preview: https://apps-ui-l0zg8d7li-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5ca434b

✅ Preview: https://apps-ui-ajcwbrrjp-iota1.vercel.app

marc2332
marc2332 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅🏻 ⚡ 💯

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 24ac3fa

✅ Preview: https://apps-ui-n1q53o5uc-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 15d4d0b

✅ Preview: https://apps-ui-kh3nidjim-iota1.vercel.app

@begonaalvarezd begonaalvarezd merged commit b571920 into develop Aug 14, 2024
24 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/rebrand-home-update-coin branch August 14, 2024 16:01
bingyanglin pushed a commit that referenced this pull request Aug 19, 2024
@evavirseda @begonaalvarezd @bingyanglin
feat(wallet): rebrand home - update coin (#1718)
e7dd423 
* feat: add card compoentn

* feat: use constants

* feat: update CoinItem component

* feat: refine icon

* fix build

* feat: update icon and images styles

* refactor: update iota-sdk name

* feat: bring back pinned coins

* feat: add clickableAction prop

* feat: remove iconSize prop

* feat: pass pinned coins to useSortedCoinsByCategories hook

* feat: add svg

* feat: update icons

* feat: minor improvements

---------

Co-authored-by: Begoña Alvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@evavirseda evavirseda

Labels
tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task (tooling/wallet)]: Rebrand Home: Update coin
4 participants
@evavirseda @begonaalvarezd @panteleymonchuk @marc2332