-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): update AddAccountPage
with template and refactor page
#1707
Merged
begonaalvarezd
merged 18 commits into
develop
from
tooling-wallet/update-addaccountpage-with-template
Aug 13, 2024
Merged
feat(wallet): update AddAccountPage
with template and refactor page
#1707
begonaalvarezd
merged 18 commits into
develop
from
tooling-wallet/update-addaccountpage-with-template
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
tooling-wallet/create-reusable-template
to
develop
August 8, 2024 11:59
panteleymonchuk
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, 2 small suggestions for improvement.
begonaalvarezd
approved these changes
Aug 13, 2024
begonaalvarezd
deleted the
tooling-wallet/update-addaccountpage-with-template
branch
August 13, 2024 15:55
bingyanglin
pushed a commit
that referenced
this pull request
Aug 19, 2024
…#1707) * feat: add header template * feat: refine AddAcountPage to use HeaderTemplate * feat: rename to PageTemplate * feat:cleanup * feat: cleanup * feat: update template * feat: revert changes * fix format * feat: refactor AddAccountPage and use PageTemplate * fix import * feat: apply suggestions * feat: use AccountsFormType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
fixes #1703
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.