Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): update AddAccountPage with template and refactor page #1707

Merged

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #1703

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested review from a team as code owners August 8, 2024 09:42
@evavirseda evavirseda added the tooling Issues related to the Tooling team label Aug 8, 2024
@evavirseda evavirseda self-assigned this Aug 8, 2024
Base automatically changed from tooling-wallet/create-reusable-template to develop August 8, 2024 11:59
Copy link
Contributor

@panteleymonchuk panteleymonchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 2 small suggestions for improvement.

apps/wallet/src/ui/app/pages/accounts/AddAccountPage.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/accounts/AddAccountPage.tsx Outdated Show resolved Hide resolved
@begonaalvarezd begonaalvarezd merged commit 99dd67c into develop Aug 13, 2024
32 of 33 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/update-addaccountpage-with-template branch August 13, 2024 15:55
bingyanglin pushed a commit that referenced this pull request Aug 19, 2024
…#1707)

* feat: add header template

* feat: refine AddAcountPage to use HeaderTemplate

* feat: rename to PageTemplate

* feat:cleanup

* feat: cleanup

* feat: update template

* feat: revert changes

* fix format

* feat: refactor AddAccountPage and use PageTemplate

* fix import

* feat: apply suggestions

* feat: use AccountsFormType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task (tooling/wallet): Update AddAccountPage with template and refactor page
3 participants