refactor(iota-indexer): Do not panic on errors in iota_indexer::framework::runner::run

[tomxey]

Description of change

Refactored iota_indexer::framework::runner::run to return the errors from handlers instead of panicking, motivated by #1569. Refactored the function to reduce code duplication.

Links to any relevant issues

fix #1569

Type of change

• Refactor

How the change has been tested

• cargo test
• ran the indexer locally and observed that checkpoints are synced without errors

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have checked that new and existing unit tests pass locally with my changes

[sergiupopescu199]

I've spotted an unwrap in the run function

iota/crates/iota-indexer/src/framework/runner.rs

Line 31 in 5ea3777

.unwrap();

[samuel-rufi]

Looks good! Only minor suggestion to fix rustfmt and the typo you mentioned above.

[tomxey]

I've spotted an unwrap in the run function

iota/crates/iota-indexer/src/framework/runner.rs

Line 31 in 5ea3777

.unwrap();

@sergiupopescu199 I skipped it since it seemed to not be in scope of #1569

[tomxey]

Looks good! Only minor suggestion to fix rustfmt and the typo you mentioned above.

@samuel-rufi Done

[samuel-rufi]

Seems like clippy is failing the CI check

[kodemartin]

Hey @tomxey looks good. Let just a few suggestions to improve the patch.

Plus, mind clippy.

[kodemartin]

lgtm 🐻‍❄️