Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devx): edit getting-started > your first dApp #1579

Merged
merged 8 commits into from
Aug 26, 2024
Merged

feat(devx): edit getting-started > your first dApp #1579

merged 8 commits into from
Aug 26, 2024

Conversation

lucas-tortora
Copy link
Contributor

Description of change

  • Edited all the articles in the Getting Started > First App section
  • Fixed sidebar

Links to any relevant issues

fixes #1389

Type of change

  • Documentation Enhancement

How the change has been tested

Docs were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@lucas-tortora lucas-tortora requested a review from a team as a code owner August 1, 2024 17:39
@lucas-tortora lucas-tortora mentioned this pull request Aug 1, 2024
Closed
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

✅ Vercel Preview Deployment is ready!

View Preview

salaheldinsoliman
salaheldinsoliman requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for some lints.

docs/content/developer/getting-started/create-a-package.mdx Outdated Show resolved Hide resolved
docs/content/developer/getting-started/create-a-package.mdx Outdated Show resolved Hide resolved
docs/content/developer/getting-started/create-a-module.mdx Outdated Show resolved Hide resolved
docs/content/developer/getting-started/connect.mdx Outdated Show resolved Hide resolved
docs/content/developer/getting-started/connect.mdx Show resolved Hide resolved
@DaughterOfMars DaughterOfMars changed the title feat(devx): edit getting-started > your firs dApp feat(devx): edit getting-started > your first dApp Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora force-pushed the devx/edit-and-refactor-your-first-dapp branch from 7dfd565 to 2766885 Compare August 13, 2024 15:14
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@DaughterOfMars
Copy link
Contributor

The getting started page seems to be empty in the preview

@lucas-tortora lucas-tortora requested a review from fijter August 15, 2024 12:42
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@DaughterOfMars
Copy link
Contributor

Maybe I'm just missing it but I don't see the "Your First dApp" page in the preview

@lucas-tortora
Copy link
Contributor Author

Maybe I'm just missing it but I don't see the "Your First dApp" page in the preview

It's been merged into the Getting Started section. I thought it made more sense that the getting started section included creating, testing, and publishing packages, rather than only connecting to the network and getting tokens.

@DaughterOfMars
Copy link
Contributor

Maybe I'm just missing it but I don't see the "Your First dApp" page in the preview

It's been merged into the Getting Started section. I thought it made more sense that the getting started section included creating, testing, and publishing packages, rather than only connecting to the network and getting tokens.

I don't see it there either?

@lucas-tortora
Copy link
Contributor Author

I don't see it there either?

The version on the left is the current PR, and the one on the right is before. Basically from Create a Move Package to Client App with IOTA TypeScript SDK. We can re-add the sub-category Your First dApp, personally I'm not a fan of the division, but if it's a clearer UX I see no reason why not.

image

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

fijter
fijter approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@fijter fijter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will clean up the examples/Move2024' them after this one has been merged and go over it all again :)

docs/content/sidebars/developer.js Outdated Show resolved Hide resolved
@lucas-tortora lucas-tortora force-pushed the devx/edit-and-refactor-your-first-dapp branch from a67867f to 1fe37cd Compare August 20, 2024 14:22
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora force-pushed the devx/edit-and-refactor-your-first-dapp branch from 1fe37cd to 2222c24 Compare August 26, 2024 12:54
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora merged commit f7d2afb into develop Aug 26, 2024
23 of 24 checks passed
@lucas-tortora lucas-tortora deleted the devx/edit-and-refactor-your-first-dapp branch August 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@salaheldinsoliman salaheldinsoliman salaheldinsoliman approved these changes

@Ginowine Ginowine Ginowine approved these changes

@fijter fijter fijter approved these changes

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron

@vivekjain23 vivekjain23 Awaiting requested review from vivekjain23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[task(docs)]: Apply Style Guide to: Developer - Your First dApp
6 participants
@lucas-tortora @DaughterOfMars @fijter @Ginowine @salaheldinsoliman @Dr-Electron