Skip to content

Commit

Permalink
fix(tooling-ci): Fix prod deploys of vercel (#3651)
Browse files Browse the repository at this point in the history
* fix(tooling-ci): Pass `isDevelop` from `hierarchy.yml` to `_vercel_deploy.yml`

* pass ref

* type: string!!!
  • Loading branch information
marc2332 authored Oct 25, 2024
1 parent a6911c2 commit d21b9dc
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
16 changes: 11 additions & 5 deletions .github/workflows/_vercel_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,15 @@ on:
shouldDeployPreview:
type: boolean
required: true
isDevelop:
type: boolean
required: true
githubRef:
type: string
required: true

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{ inputs.githubRef }}
cancel-in-progress: true

jobs:
Expand All @@ -37,7 +43,7 @@ jobs:

explorer-prod:
name: Vercel Explorer Production
if: github.ref_name == 'develop' && inputs.isExplorer
if: inputs.isDevelop && inputs.isExplorer
uses: ./.github/workflows/apps-explorer.deploy.yml
secrets: inherit
with:
Expand All @@ -53,7 +59,7 @@ jobs:

ui-kit-prod:
name: Vercel UI Kit Preview
if: github.ref_name == 'develop' && inputs.isAppsUiKit
if: inputs.isDevelop && inputs.isAppsUiKit
uses: ./.github/workflows/apps-ui-kit.deploy.yml
secrets: inherit
with:
Expand All @@ -69,7 +75,7 @@ jobs:

wallet-dashboard-prod:
name: Vercel Wallet Dashboard Production
if: github.ref_name == 'develop' && inputs.isWalletDashboard
if: inputs.isDevelop && inputs.isWalletDashboard
uses: ./.github/workflows/apps-wallet-dashboard.deploy.yml
secrets: inherit
with:
Expand All @@ -85,7 +91,7 @@ jobs:

apps-backend-prod:
name: Vercel apps-backend Production
if: github.ref_name == 'develop' && inputs.isAppsBackend
if: inputs.isDevelop && inputs.isAppsBackend
uses: ./.github/workflows/apps-backend.deploy.yml
secrets: inherit
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/hierarchy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ jobs:
isAppsBackend: ${{ needs.diff.outputs.isAppsBackend == 'true' }}
isAppsUiKit: ${{ needs.diff.outputs.isAppsUiKit == 'true' }}
isWalletDashboard: ${{ needs.diff.outputs.isWalletDashboard == 'true' }}
isDevelop: ${{ github.ref_name == 'develop' }}
githubRef: ${{ github.event.pull_request.number || github.ref }}

ledgernano:
if: (!cancelled() && !failure()) && needs.diff.outputs.isLedgerjs == 'true' && github.event.pull_request.draft == false
Expand Down

0 comments on commit d21b9dc

Please sign in to comment.