Skip to content

Commit

Permalink
fix: Skip the authority conservation checks for now
Browse files Browse the repository at this point in the history
  • Loading branch information
PhilippGackstatter committed Jul 1, 2024
1 parent 22d3c09 commit af21774
Showing 1 changed file with 18 additions and 15 deletions.
33 changes: 18 additions & 15 deletions crates/iota-core/src/authority.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2981,21 +2981,24 @@ impl AuthorityState {
cur_epoch_store.epoch()
);

if let Err(err) = self
.execution_cache
.expensive_check_iota_conservation(cur_epoch_store)
{
if cfg!(debug_assertions) {
panic!("{}", err);
} else {
// We cannot panic in production yet because it is known that there are some
// inconsistencies in testnet. We will enable this once we make it balanced
// again in testnet.
warn!("Iota conservation consistency check failed: {}", err);
}
} else {
info!("Iota conservation consistency check passed");
}
// Skip the iota conservation check since it will be violated due to inflation/deflation for validator rewards.
// TODO: Investigate whether we can still keep this check for something useful or if it needs to be removed entirely.

// if let Err(err) = self
// .execution_cache
// .expensive_check_iota_conservation(cur_epoch_store)
// {
// if cfg!(debug_assertions) {
// panic!("{}", err);
// } else {
// // We cannot panic in production yet because it is known that there are some
// // inconsistencies in testnet. We will enable this once we make it balanced
// // again in testnet.
// warn!("Iota conservation consistency check failed: {}", err);
// }
// } else {
// info!("Iota conservation consistency check passed");
// }

// check for root state hash consistency with live object set
if expensive_safety_check_config.enable_state_consistency_check() {
Expand Down

0 comments on commit af21774

Please sign in to comment.