Merge branch 'dev-tools/fix-more-tests' of https://github.com/iotaled…

…ger/iota into dev-tools/fix-more-tests

.gitignore

@@ -77,3 +77,8 @@ docs/content/references/framework/**
 
 lcov.info
 **/venv/
+
+# iota-private-network
+docker/iota-private-network/data
+docker/iota-private-network/configs/validators/validator*
+docker/iota-private-network/configs/genesis/genesis.blob

apps/wallet/configs/webpack/webpack.config.common.ts

@@ -33,7 +33,7 @@ function generateDateVersion(patch: number) {
 }
 
 const WALLET_BETA = process.env.WALLET_BETA === 'true';
-const PATCH_VERISON = Number(process.env.PATCH_VERSION) || 0;
+const PATCH_VERSION = Number(process.env.PATCH_VERSION) || 0;
 
 const SDK_ROOT = resolve(__dirname, '..', '..', '..', '..', 'sdk');
 const PROJECT_ROOT = resolve(__dirname, '..', '..');
@@ -99,7 +99,7 @@ async function generateAliasFromTs() {
 
 const commonConfig: () => Promise<Configuration> = async () => {
     const alias = await generateAliasFromTs();
-    const walletVersionDetails = generateDateVersion(PATCH_VERISON);
+    const walletVersionDetails = generateDateVersion(PATCH_VERSION);
     const sentryAuthToken = process.env.SENTRY_AUTH_TOKEN;
     return {
         context: SRC_ROOT,

apps/wallet/src/background/accounts-finder/accounts-finder.ts

@@ -31,7 +31,7 @@ export async function findAccounts(
     getBalance: GetBalanceCallback,
     gasTypeArg: string,
 ): Promise<AccountFromFinder[]> {
-    // TODO: first check that accounts: Account[] is correctly sorted, if not, throw exception or somethintg
+    // TODO: first check that accounts: Account[] is correctly sorted, if not, throw exception or something
     // Check new addresses for existing accounts
     if (addressGapLimit > 0) {
         for (const account of accounts) {

apps/wallet/src/background/storage-migration.ts

@@ -11,7 +11,7 @@ const MIGRATION_DONE_STORAGE_KEY = 'storage-migration-done';
 let statusCache: Status | null = null;
 
 export async function getStatus() {
-    // placeholde for migration status, always returns ready
+    // placeholder for migration status, always returns ready
     if (statusCache) {
         return statusCache;
     }

apps/wallet/src/ui/app/pages/accounts/manage/AccountGroup.tsx

@@ -41,7 +41,7 @@ export function getGroupTitle(aGroupAccount: SerializedUIAccount) {
     return ACCOUNT_TYPE_TO_LABEL[aGroupAccount?.type] || '';
 }
 
-// todo: we probbaly have some duplication here with the various FooterLink / ButtonOrLink
+// todo: we probably have some duplication here with the various FooterLink / ButtonOrLink
 // components - we should look to add these to base components somewhere
 const FooterLink = forwardRef<HTMLAnchorElement | HTMLButtonElement, ButtonOrLinkProps>(
     ({ children, to, ...props }, ref) => {

crates/iota-aws-orchestrator/assets/plot.py

@@ -1,6 +1,4 @@
 # Copyright (c) Mysten Labs, Inc.
-# SPDX-License-Identifier: Apache-2.0
-
 # Modifications Copyright (c) 2024 IOTA Stiftung
 # SPDX-License-Identifier: Apache-2.0
 

crates/iota-bridge/src/iota_syncer.rs

@@ -81,7 +81,7 @@ where
 
     async fn run_event_listening_task(
         // The module where interested events are defined.
-        // Moudle is always of bridge package 0x9.
+        // Module is always of bridge package 0x9.
         module: Identifier,
         mut cursor: EventID,
         events_sender: mysten_metrics::metered_channel::Sender<(Identifier, Vec<IotaEvent>)>,

crates/iota-bridge/src/orchestrator.rs

@@ -217,7 +217,7 @@ mod tests {
 
     #[tokio::test]
     async fn test_iota_watcher_task() {
-        // Note: this test may fail beacuse of the following reasons:
+        // Note: this test may fail because of the following reasons:
         // the IotaEvent's struct tag does not match the ones in events.rs
 
         let (iota_events_tx, iota_events_rx, _eth_events_tx, eth_events_rx, iota_client, store) =
@@ -268,7 +268,7 @@ mod tests {
 
     #[tokio::test]
     async fn test_eth_watcher_task() {
-        // Note: this test may fail beacuse of the following reasons:
+        // Note: this test may fail because of the following reasons:
         // 1. Log and BridgeAction returned from `get_test_log_and_action` are not in
         //    sync
         // 2. Log returned from `get_test_log_and_action` is not parseable log (not

crates/iota-config/src/node.rs

@@ -8,7 +8,6 @@ use std::{
     path::{Path, PathBuf},
     sync::Arc,
     time::Duration,
-    usize,
 };
 
 use anyhow::Result;

crates/iota-core/src/authority.rs

@@ -3566,12 +3566,12 @@ impl AuthorityState {
                     .rev()
                     .skip_while(|d| cursor.is_some() && Some(*d) != cursor)
                     .skip(usize::from(cursor.is_some()));
-                return Ok(iter.take(limit.unwrap_or(usize::max_value())).collect());
+                return Ok(iter.take(limit.unwrap_or(usize::MAX)).collect());
             } else {
                 let iter = iter
                     .skip_while(|d| cursor.is_some() && Some(*d) != cursor)
                     .skip(usize::from(cursor.is_some()));
-                return Ok(iter.take(limit.unwrap_or(usize::max_value())).collect());
+                return Ok(iter.take(limit.unwrap_or(usize::MAX)).collect());
             }
         }
         self.get_indexes()?

crates/iota-core/src/authority/test_authority_builder.rs

@@ -223,10 +223,7 @@ impl<'a> TestAuthorityBuilder<'a> {
             None,
         )
         .unwrap();
-        let expensive_safety_checks = match self.expensive_safety_checks {
-            None => ExpensiveSafetyCheckConfig::default(),
-            Some(config) => config,
-        };
+        let expensive_safety_checks = self.expensive_safety_checks.unwrap_or_default();
         let cache = Arc::new(ExecutionCache::new_for_tests(
             authority_store.clone(),
             &registry,

crates/iota-core/src/transaction_manager.rs

@@ -68,6 +68,7 @@ pub struct TransactionManager {
 #[derive(Clone, Debug)]
 pub struct PendingCertificateStats {
     // The time this certificate enters transaction manager.
+    #[cfg(test)]
     pub enqueue_time: Instant,
     // The time this certificate becomes ready for execution.
     pub ready_time: Option<Instant>,
@@ -554,6 +555,7 @@ impl TransactionManager {
                 expected_effects_digest,
                 waiting_input_objects: input_object_keys,
                 stats: PendingCertificateStats {
+                    #[cfg(test)]
                     enqueue_time: pending_cert_enqueue_time,
                     ready_time: None,
                 },

crates/iota-framework/docs/iota-framework/kiosk.md

@@ -276,7 +276,7 @@ A capability which locks an item and gives a permission to
 purchase it from a <code><a href="kiosk.md#0x2_kiosk_Kiosk">Kiosk</a></code> for any price no less than <code>min_price</code>.
 
 Allows exclusive listing: only bearer of the <code><a href="kiosk.md#0x2_kiosk_PurchaseCap">PurchaseCap</a></code> can
-purchase the asset. However, the capablity should be used
+purchase the asset. However, the capability should be used
 carefully as losing it would lock the asset in the <code><a href="kiosk.md#0x2_kiosk_Kiosk">Kiosk</a></code>.
 
 The main application for the <code><a href="kiosk.md#0x2_kiosk_PurchaseCap">PurchaseCap</a></code> is building extensions

crates/iota-framework/packages/iota-framework/sources/kiosk/kiosk.move

@@ -163,7 +163,7 @@ module iota::kiosk {
     /// purchase it from a `Kiosk` for any price no less than `min_price`.
     ///
     /// Allows exclusive listing: only bearer of the `PurchaseCap` can
-    /// purchase the asset. However, the capablity should be used
+    /// purchase the asset. However, the capability should be used
     /// carefully as losing it would lock the asset in the `Kiosk`.
     ///
     /// The main application for the `PurchaseCap` is building extensions

crates/iota-framework/packages/move-stdlib/tests/vector_tests.move

@@ -433,9 +433,9 @@ module std::vector_tests {
         assert!(index == 1, 1);
     }
 
-    // index_of will return the index first occurence that is equal
+    // index_of will return the index first occurrence that is equal
     #[test]
-    fun index_of_nonempty_has_multiple_occurences() {
+    fun index_of_nonempty_has_multiple_occurrences() {
         let mut v = vector[];
         v.push_back(false);
         v.push_back(true);