Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Native Tokens across Chains Guide #1609

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Send Native Tokens across Chains Guide #1609

merged 8 commits into from
Jun 19, 2024

Conversation

Ginowine
Copy link
Contributor

@Ginowine Ginowine commented Jun 11, 2024 •
edited
Loading

Description of change

This PR creates a guide on how to transfer native tokens from the L1 native token to the L2 EVM account.

Links to any relevant issues

fixes #1608.

Type of change

  • Documentation Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

vivekjain23
vivekjain23 requested changes Jun 12, 2024
View reviewed changes
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
salaheldinsoliman
salaheldinsoliman requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments

docs/build/isc/v1.3-alpha/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.3-alpha/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.3-alpha/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.3-alpha/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
@lucas-tortora lucas-tortora marked this pull request as ready for review June 12, 2024 15:24
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 20dbd3a

✅ Preview: https://iota-wiki-kpmsjcmm9-iota1.vercel.app

lucas-tortora
lucas-tortora requested changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great article :) Just some minor suggestions. Please apply them to both 1.1 and 1.3 versions

docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Show resolved Hide resolved
lucas-tortora
lucas-tortora approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some `` it LGTM :)

docs/build/isc/v1.1/docs/how-tos/core-contracts/token/send-token-across-chains.mdx Outdated Show resolved Hide resolved
@Ginowine
Copy link
Contributor Author

@lucas-tortora, I have made the suggested update.

salaheldinsoliman
salaheldinsoliman approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ginowine LGTM

@Ginowine Ginowine force-pushed the isc-wiki/send-token-across-chain branch from 72fb758 to 8b20879 Compare June 19, 2024 15:22
@lucas-tortora lucas-tortora marked this pull request as draft June 19, 2024 16:14
@lucas-tortora lucas-tortora marked this pull request as ready for review June 19, 2024 16:14
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8b20879

✅ Preview: https://iota-wiki-h5vmenma6-iota1.vercel.app

@lucas-tortora lucas-tortora merged commit 8aac9da into main Jun 19, 2024
10 checks passed
@lucas-tortora lucas-tortora deleted the isc-wiki/send-token-across-chain branch June 19, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@salaheldinsoliman salaheldinsoliman salaheldinsoliman approved these changes

@jlvandenhout jlvandenhout Awaiting requested review from jlvandenhout

@vivekjain23 vivekjain23 Awaiting requested review from vivekjain23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Guide on how to send Tokens across Chains
4 participants
@Ginowine @salaheldinsoliman @lucas-tortora @vivekjain23