Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update theme types #1542

Closed
wants to merge 1 commit into from
Closed

Update theme types #1542

wants to merge 1 commit into from

Conversation

Dr-Electron
Copy link
Collaborator

Description of change

Updated the theme types

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@Dr-Electron Dr-Electron marked this pull request as ready for review April 30, 2024 20:40
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: efe901e

✅ Preview: https://iota-wiki-efd7mqq37-iota1.vercel.app

@jlvandenhout
Copy link
Contributor

jlvandenhout commented Apr 30, 2024 •
edited
Loading

We're using Typescript to implement our client-side logic and swizzled components. IMO we should export and use types of our own packages properly. It's little to no effort.

@Dr-Electron
Copy link
Collaborator Author

As we move Theme this PR is deprecated anyway

@Dr-Electron Dr-Electron deleted the update-theme-types branch May 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dr-Electron @jlvandenhout