Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make network info table components #1521

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Conversation

jlvandenhout
Copy link
Contributor

@jlvandenhout jlvandenhout commented Mar 19, 2024

Description of change

This changes the network info tables re-usable components.

TODO:

  • Use them in other appropriate places

Links to any relevant issues

Fixes iotaledger/devx#344

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@jlvandenhout
Copy link
Contributor Author

@lucas-tortora are there any other places where you would like to see these tables?

@jlvandenhout jlvandenhout marked this pull request as ready for review March 19, 2024 14:04
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 127942e

✅ Preview: https://iota-wiki-5ja57sy6f-iota1.vercel.app

@lucas-tortora
Copy link
Collaborator

@lucas-tortora are there any other places where you would like to see these tables?

I think only docs/build/isc/v1.0.0-rc.6/docs/getting-started/networks-and-chains.mdx, docs/build/isc/v1.0.0-rc.6/docs/getting-started/tools.mdx for the time being

@jlvandenhout jlvandenhout force-pushed the feat/network-info-component branch from 127942e to 58039d0 Compare March 24, 2024 10:22
@jlvandenhout
Copy link
Contributor Author

@lucas-tortora I updated those pages too, can you check again?

@jlvandenhout jlvandenhout merged commit 233fc38 into main Mar 25, 2024
12 checks passed
@jlvandenhout jlvandenhout deleted the feat/network-info-component branch March 25, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create components that display the tables in the Networks and Endpoints section
2 participants