ISC - Exchange Guide for ShimmerEVM #1502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been deployed to Vercel. Latest commit: d97ae4c ✅ Preview: https://iota-wiki-9wsx0rnpl-iota1.vercel.app/wasp-evm/how-tos/integrate-your-exchange/ |
jlvandenhout
reviewed
Mar 1, 2024
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Outdated
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Outdated
Show resolved
Hide resolved
Comment on lines
14
to
16
| URL (https://json-rpc.evm.shimmer.network) and ChainId (<ChainId url='https://json-rpc.evm.shimmer.network'/>), and run | ||
| our [Hornet](/hornet/welcome/) node with the [Wasp](/wasp/running-a-node/) INX-plugin. | ||
|
|
There was a problem hiding this comment.
Suggested change
| URL (https://json-rpc.evm.shimmer.network) and ChainId (<ChainId url='https://json-rpc.evm.shimmer.network'/>), and run | |
| our [Hornet](/hornet/welcome/) node with the [Wasp](/wasp/running-a-node/) INX-plugin. | |
| URL (https://json-rpc.evm.shimmer.network) and ChainId (<ChainId url='https://json-rpc.evm.shimmer.network'/>), or set up your own [Hornet](/hornet/welcome/) node with the [Wasp](/wasp/running-a-node/) INX-plugin and get peered with the existing ShimmerEVM network. |
If you use the public endpoint, you don't need to run your own node cluster right? So either connect to the public endpoint, or use your own cluster of Hornet and Wasp nodes. However, in the latter case, there is a procedure to be followed to actually get peered to the existing network of ShimmerEVM Wasp nodes right?
There was a problem hiding this comment.
Yes, which isn't documented yet tho 🤔 So we should extent it once it is. SoonTM
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
…change.mdx Co-authored-by: Jeroen van den Hout <[email protected]>
…change.mdx Co-authored-by: Jeroen van den Hout <[email protected]>
jorgemmsilva
suggested changes
Mar 4, 2024
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
|
|
||
| If you already support EVM, then you probably are already familiar with what you'll need to integrate ShimmerEVM. As | ||
| with most networks, you should be able to use the same [JSON RPC API](https://wiki.iota.org/wasp-evm/reference/json-rpc-spec/) or clients, like [go-ethereum](https://geth.ethereum.org/), taking into account the | ||
| [compatibility and limitations](../getting-started/compatibility.md), use the ShimmerEVM RPC |
There was a problem hiding this comment.
this page linked is full of wrong/irrelevant info:
https://iota-wiki-9wsx0rnpl-iota1.vercel.app/wasp-evm/getting-started/compatibility/#properties-and-limitations
- why do we talk about "on-ledger" requests on "EVM limitations"? that's not part of the EVM...
- "Wrapped Calls to the JSON-RPC" ??? why does this even matter? it's just an implementation detail.
- "Contract ID Source", "WASM Root Contract List", wtf...
- "EVM state resides in a raw form to prevent the duplication of efforts undertaken by the ISC layer" - what?
that entire page should be scrapped.
please just keep:
No Enforced Block Time- use the "shimmerEVM" avg block time insteadThe Magic Contract- use "Layer 1 tokens" ,instead of ISC tokens , remove "generally avail"Gas Fees- rewrite and simply state that "the gas price is set by the chain"
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Outdated
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
docs/build/wasp-evm/v1.0.0-rc.6/docs/how-tos/integrate-your-exchange.mdx
Show resolved
Hide resolved
…change.mdx Co-authored-by: Jorge Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
first draft, exchange guide for ShimmerEVM
DO NOT MERGE THIS UNTIL IT'S BEEN REVIEWED BY A SUBJECT EXPERT
Links to any relevant issues
fixes iotaledger/devx#319
Type of change
Change checklist